Add /deliver-issue command for bounded independent-review delivery #15
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Creatidy/creatidy-kernel#15
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Goal
Add
/deliver-issuefor one owner-selected issue through implementation, validation, one PR todevelop, fresh independent full-PR review and bounded remediation, ending atREADY_FOR_OWNER_MERGEwithout merging. Each independent review is a new Scarcity Router dispatch boundary using the existing repository-review capability contract.Why
The K2A pilot needed eight valid reviews and six remediation cycles; fresh full review uncovered defects missed by targeted rechecks. Review/budget state must survive fresh sessions without the owner relaying messages. The review provider/model/variant must be capability-routed, not selected by static repository assignment or the implementation model.
Scope
.kilo/command/deliver-issue.mdas a small orchestration contract reusing/implement-issueand/review-pr, plus a concise always-visibleAGENTS.mdrule. Clarify the existing implementation guidance only where required to remove a direct contradiction.develop, repository validation before PR and after changed HEAD, one PR todevelop, nomainmodification/targeting, no auto-merge, and issue left open until owner integration.repository_reviewand monotone tightening from actual task capability requirements, known author capability floor when available, and review criticality. Architecture/security and remediation reviews use the existing L4 / at-least-5/5/5 requirement. Call the router exactly once per dispatch boundary; use only its eligible returned selection or ordered eligible alternatives under the existing harness-fallback policy. No locally hard-coded model/provider/variant, reviewer ranking or fallback table; do not weaken requirements.mode=local,versions=falseat request level and each task's/review-pr <PR URL>prompt plus router-selected model, adapted provider ID, and exact variant insidetasks[]. Do not guess identifiers or variants; use only the existing provider-ID adapter.Resolved modelsevidence beforeDISPATCH_VERIFIED; distinguish router selection, dispatch request, verification, reviewer completion and verdict. Mismatch/missing evidence isNOT_RUN, consumes no review/remediation cycle, and requires diagnosis/corrected payload rather than silent substitution.max_remediation_cycles = 10; only valid in-scope implementation remediation costs one cycle. Remediate on the same issue, branch and PR.Acceptance Criteria
/deliver-issuedefines exactly four terminal conditions:READY_FOR_OWNER_MERGE,REMEDIATION_BUDGET_EXHAUSTED,REVIEW_INFRASTRUCTURE_BLOCKED, andGENUINE_OWNER_DECISION_REQUIRED; approval alone is insufficient.repository_reviewplus monotone tightening of actual task capability floor, known author floor when available, and criticality; architecture/security and remediation are L4 and at least{reasoning:5,coding:5,tool_use:5}with required reasoning mode and tool use. Every review HEAD, including architecture-correction, gets exactly one new Router selection.mode=local,versions=falseand task-level prompt/model/provider/variant fields; requires the exact routed identity after only the existing provider adapter and matchingResolved modelsevidence beforeDISPATCH_VERIFIED.NOT_RUN; it has no hard-coded model/provider, local reviewer ranking/fallback, no weakened requirements, and follows the parent harness-fallback policy only for Router-returned eligible alternatives.main.make checkandmake package-checkpass on amended PR #16, required CI succeeds, and a fresh independently routed reviewer reviews the whole amended PR against this issue without merging.Constraints
This is public repository development workflow guidance, not Kernel product/runtime model routing or a new Kernel dependency on Scarcity Router or the parent workspace. Reuse the existing Creatidy repository-review routing and harness-adapter policy; do not copy private runtime details or invent a substitute. Keep the change in
.kilo/command/deliver-issue.mdandAGENTS.mdunless an actual governance contradiction requires a clarification. Do not add a Markdown Program engine, generic workflow framework, secrets, status taxonomy, or product/domain code. Preserve normal single-issue development.Links
.kilo/command/implement-issue.md.kilo/command/review-pr.mdAGENTS.mdand.kilo/rules/Non-Goals
No Program execution engine, Projects, milestones, labels, private parent repository dependency, automatic merge, or implementation of unrelated product behavior. No static reviewer model/provider/variant, local reviewer ranking, or local fallback table.
Delivery ledger initialized for #15 / PR #16:
issue-15-deliver-issue->develop; current HEAD6e29a5b788e69ca3b7f175f1b5fc26ff9000c27b;max_remediation_cycles=10,remediation_used=0/10, valid review cycles=0. Changed:.kilo/command/deliver-issue.md,AGENTS.md.make checkPASS (142 tests; formatting/lint/typing/imports/secret scan),make package-checkPASS,git diff --checkPASS. CI and fresh independent critical review pending; issue remains open and PR will not be merged. The editor config hot-reload reportedNo context found for instanceon creation despite matching existing command frontmatter; nokiloCLI is installed to independently test slash-command registration.Delivery ledger, valid full review cycle 1 for PR #16: reviewed HEAD
6e29a5b788e69ca3b7f175f1b5fc26ff9000c27b->develop; classcritical-independent-review; independent review #595. Dispatch: reviewer requested, configuration valid, explicit model-resolution evidence observed, fresh distinct read-only session completed, full-review verdict obtained. Substantive verdict: APPROVE; Forgejo recorded state: COMMENT, because the sharedkiloMCP identity equals the PR author and Forgejo rejected an APPROVED-state self-review. Blockers: none. Remediation: none; resulting HEAD unchanged;remediation_used=0/10(max_remediation_cycles=10). Exact-HEAD localmake checkandmake package-checkPASS (also independently rerun by reviewer); required Forgejo PR CI run 26 succeeded for this SHA; #15 acceptance criteria met. Delivery-contract terminal condition:READY_FOR_OWNER_MERGE(no merge performed). Limitation: this is not a platform-recorded APPROVED review; a separate Forgejo identity may be necessary to satisfy any branch-protection approval rule. Branch-protection settings could not be inspected with the current MCP identity. Live slash-command registration remains unobserved after the editor hot-reload error.Delivery ledger continuation for existing PR #16 after owner-directed Issue #15 contract refinement: previous full review cycle 1 #595 and owner approval #596 apply only to old HEAD
6e29a5b788e69ca3b7f175f1b5fc26ff9000c27b. Its priorREADY_FOR_OWNER_MERGEledger entry is superseded for the new HEAD, not rewritten. Owner-directed governance amendment changed current PR HEAD toeaf0211ce6f41c551b7650ce8cdfbf140a10b4f6on the sameissue-15-deliver-issuebranch ->develop; it is not reviewer-requested remediation.max_remediation_cycles=10,remediation_used=0/10, valid full review cycles=1; new bound Astra/OpenAI/max full review cycle 2 is pending (not yet counted). Changes:.kilo/command/deliver-issue.md,AGENTS.md, and.kilo/rules/30-implementation-discipline.md(narrow carve-out of its explicit Markdown routing prohibition). Exact-HEADmake checkPASS (142 tests),make package-checkPASS,git diff --checkPASS. Required CI and new independent review pending; issue remains open and PR unmerged.Delivery ledger, valid independent full PR review cycle 2 for existing PR #16: reviewed HEAD
eaf0211ce6f41c551b7650ce8cdfbf140a10b4f6->develop; bound reviewerGPT-6 Astra / openai / max, fresh local Agent Manager session. Dispatch states:REQUESTED; task-levelmodel/provider/variantand request-levelmode=local,versions=falsevalidated; explicit Agent ManagerResolved models: GPT-6 Astra (openai) / maxreceipt observed ->DISPATCH_VERIFIED; reviewer session completed; full current-PR verdict obtained in review #597. Substantive recommendation: APPROVE; Forgejo recorded state: COMMENT, since the configuredkiloMCP identity equals the PR author and Forgejo rejectedAPPROVEDas self-approval. This is not a platform-recorded approving review. Blockers: none; one nonblocking suggestion on explicit evidence-retry bound, no remediation. Resulting HEAD unchanged:eaf0211ce6f41c551b7650ce8cdfbf140a10b4f6;remediation_used=0/10,max_remediation_cycles=10, valid full review cycles=2 including stale old-HEAD cycle 1. Exact-HEAD localmake checkPASS (142 tests),make package-checkPASS,git diff --checkPASS; required Forgejo PR CI run 27 succeeded for this SHA; updated Issue #15 acceptance criteria met, no unresolved blocking findings, current PR head verified unchanged. Delivery-contract terminal condition:READY_FOR_OWNER_MERGE(issue open, PR unmerged). Limitations: platform approval may require a distinct Forgejo identity/renewed owner approval; branch-protection settings and live slash-command registration remain unverified. Prior owner approval #596 is stale and not counted for this HEAD.Delivery ledger continuation for existing PR #16 after the latest owner-directed routing correction. Current HEAD
a8c7cfe0ca80a27a9c176e4d5ce4af8c7b66d4ed->develop(06c374be43fc0781912a16cba0788821d6973090); sameissue-15-deliver-issuebranch. The previous valid full-review cycles (cycle 1 at6e29a5b…, cycle 2 ateaf0211…) and owner approval #596 apply only to old HEADs and are stale; preserve as history, not current acceptance.max_remediation_cycles=10;remediation_used=0/10. This owner-directed correction is not remediation.Current review routing attempt: frozen the exact current HEAD/base; review classified architecture/security-critical because this PR changes governance of reviewer dispatch; requested Scarcity Router
profile_id=repository_review, monotonetightening={task_level:L4, capability_minima:{reasoning:5,coding:5,tool_use:5}, hard_constraints:{requires_tool_use:true, requires_reasoning_mode:true}}. Scarcity Router returned onlyinvalid_request/invalid request, with no route selection. The exact payload was checked against parentcreatidy-autonomyreview-routing builder/tests and parsed successfully by local Scarcity Router v1parse_selection_document; the local model policy containsrepository_review(policy v8). This did not identify a corrected input, so no speculative/weakened request or alternative profile was sent.REQUESTEDto Agent Manager: no;DISPATCH_VERIFIED: no; reviewer session: not launched; review/verdict:NOT_RUN. No current-HEAD review cycle incremented; historical valid full-review count remains 2. No remediation budget used.Validation at this exact HEAD:
make checkPASS (142 tests),make package-checkPASS,git diff --checkPASS; required exact-SHA Forgejo CI run 28 succeeded. Worktree clean. Terminal delivery condition:REVIEW_INFRASTRUCTURE_BLOCKEDbecause no valid Router result was obtained for required fresh independent review. Issue remains open; PR #16 remains unmerged. A later review must make a newrepository_reviewRouter selection for its then-current frozen HEAD; do not reuse any historical route.