Separate substantive review verdict from Forgejo review state in issue delivery #19

New issue

Closed

opened 2026-09-26 08:45:59 +00:00 by kilo · 1 comment

kilo commented

2026-09-26 08:45:59 +00:00

Member

Goal

Correct the Kernel /deliver-issue development workflow so a fresh independent reviewer's substantive verdict is distinct from Forgejo's persisted review state under the shared PR-author account.

Why

Forgejo refuses a formal APPROVED review from the shared kilo identity that created the PR. A valid independent reviewer can substantively recommend APPROVE with zero blockers while Forgejo records COMMENT; treating that platform state as the review judgment incorrectly blocks delivery, as demonstrated by PR #18.

Scope

Update .kilo/command/deliver-issue.md to record substantive_verdict, forgejo_review_state, platform_approval_recorded, blocking finding count, and any platform_identity_limitation separately in its durable ledger and terminal evaluation.
Make exact-HEAD READY_FOR_OWNER_MERGE depend on valid independently dispatched full review, substantive APPROVE, zero unresolved blockers, green local validation/required CI, and issue acceptance, not intrinsically on a formal Forgejo APPROVED state. Preserve any observed branch-protection requirement for formal approval as a separate concrete platform merge condition.
Keep substantive REQUEST_CHANGES remediation and genuine substantive COMMENT non-approval independent of platform persistence; do not infer approval from arbitrary comment text.
Clarify .kilo/command/review-pr.md so ### Overall Recommendation is the substantive verdict on the frozen HEAD and review submissions preserve/report the actual Forgejo state without claiming formal approval when downgraded.

Acceptance Criteria

The command clearly distinguishes substantive verdict from persisted Forgejo state and platform approval evidence, including a shared-author identity downgrade APPROVE -> COMMENT without incorrectly declaring review infrastructure blocked.
READY_FOR_OWNER_MERGE, remediation on substantive REQUEST_CHANGES, and non-approval for substantive COMMENT are stated with exact-HEAD evidence and zero unresolved blockers.
The ledger stores the four separate facts, blocking finding count and limitation when present; historical reviews are not rewritten.
The review command preserves exact frozen HEAD, blocking findings, substantive ### Overall Recommendation, and truthful platform review state.
Only the two command documents change; make check and make package-check pass; one PR to develop receives fresh independent review without auto-merge.

Constraints

This is only Kernel development workflow governance. Do not modify issue #6 or PR #18 implementation, product/domain code, routing, Agent Manager dispatch, remediation budget, or parent-workspace M5-B contract. Do not auto-merge or target main. For this corrective PR only, the owner explicitly authorizes relying on the independent reviewer's substantive verdict when a Forgejo COMMENT is solely the shared-author account restriction; record the actual state.

Links

Triggering PR: #18
Existing delivery workflow issue: #15
.kilo/command/deliver-issue.md
.kilo/command/review-pr.md

## Goal Correct the Kernel `/deliver-issue` development workflow so a fresh independent reviewer's substantive verdict is distinct from Forgejo's persisted review state under the shared PR-author account. ## Why Forgejo refuses a formal `APPROVED` review from the shared `kilo` identity that created the PR. A valid independent reviewer can substantively recommend `APPROVE` with zero blockers while Forgejo records `COMMENT`; treating that platform state as the review judgment incorrectly blocks delivery, as demonstrated by PR #18. ## Scope - Update `.kilo/command/deliver-issue.md` to record `substantive_verdict`, `forgejo_review_state`, `platform_approval_recorded`, blocking finding count, and any `platform_identity_limitation` separately in its durable ledger and terminal evaluation. - Make exact-HEAD `READY_FOR_OWNER_MERGE` depend on valid independently dispatched full review, substantive `APPROVE`, zero unresolved blockers, green local validation/required CI, and issue acceptance, not intrinsically on a formal Forgejo `APPROVED` state. Preserve any observed branch-protection requirement for formal approval as a separate concrete platform merge condition. - Keep substantive `REQUEST_CHANGES` remediation and genuine substantive `COMMENT` non-approval independent of platform persistence; do not infer approval from arbitrary comment text. - Clarify `.kilo/command/review-pr.md` so `### Overall Recommendation` is the substantive verdict on the frozen HEAD and review submissions preserve/report the actual Forgejo state without claiming formal approval when downgraded. ## Acceptance Criteria - [ ] The command clearly distinguishes substantive verdict from persisted Forgejo state and platform approval evidence, including a shared-author identity downgrade `APPROVE -> COMMENT` without incorrectly declaring review infrastructure blocked. - [ ] `READY_FOR_OWNER_MERGE`, remediation on substantive `REQUEST_CHANGES`, and non-approval for substantive `COMMENT` are stated with exact-HEAD evidence and zero unresolved blockers. - [ ] The ledger stores the four separate facts, blocking finding count and limitation when present; historical reviews are not rewritten. - [ ] The review command preserves exact frozen HEAD, blocking findings, substantive `### Overall Recommendation`, and truthful platform review state. - [ ] Only the two command documents change; `make check` and `make package-check` pass; one PR to `develop` receives fresh independent review without auto-merge. ## Constraints This is only Kernel development workflow governance. Do not modify issue #6 or PR #18 implementation, product/domain code, routing, Agent Manager dispatch, remediation budget, or parent-workspace M5-B contract. Do not auto-merge or target `main`. For this corrective PR only, the owner explicitly authorizes relying on the independent reviewer's substantive verdict when a Forgejo `COMMENT` is solely the shared-author account restriction; record the actual state. ## Links - Triggering PR: https://forgejo.creatidy.com/Creatidy/creatidy-kernel/pulls/18 - Existing delivery workflow issue: https://forgejo.creatidy.com/Creatidy/creatidy-kernel/issues/15 - `.kilo/command/deliver-issue.md` - `.kilo/command/review-pr.md`

kilo referenced this issue

2026-09-26 08:50:29 +00:00

[Governance] Separate substantive review verdict from Forgejo state #20

kilo commented

2026-09-26 08:51:03 +00:00

Author

Member

Governance correction implemented on issue-19-review-verdict at exact HEAD 9517804008bd212b89cd7799e7052b18585fb313. PR: #20 -> develop; only .kilo/command/deliver-issue.md and .kilo/command/review-pr.md changed. Issue #6 / PR #18 implementation untouched.

Validation at this HEAD: make check passed (152 tests and format/lint/type/import/secret/diff gates); make package-check passed; Forgejo CI run #1950 succeeded (https://forgejo.creatidy.com/Creatidy/creatidy-kernel/actions/runs/34). Dependencies/tooling unchanged, so make audit was not rerun.

Fresh independent full review #604 (#20 (comment)), exact frozen HEAD above/base 059482d045bd8e772005c9fbc1a9b89ce64ce26f: routed repository_review L4, minimum reasoning/coding/tool_use 5/5/5 with required tool use/reasoning mode; Router selected zai/glm-5.3/max (catalog v4, profile policy v8, degraded=false), dispatched GLM-5.3/zai-coding-plan/max under documented provider adapter, Agent Manager resolution verified, fresh session ses_f2315fdc8ffeGowH1UpmCBG9Jp / request am-1790412718534-aykyif. substantive_verdict = APPROVE; blocking findings = 0; forgejo_review_state = COMMENT; platform_approval_recorded = false. Forgejo rejected formal APPROVED with approve your own pull is not allowed because both PR author and configured reviewer account are kilo; the reviewer preserved substantive APPROVE in ### Overall Recommendation. The issue's owner authorization permits this substantive verdict for this corrective PR. No unresolved blocker; PR remains open and unmerged; issue remains open until owner integration.

Governance correction implemented on `issue-19-review-verdict` at exact HEAD `9517804008bd212b89cd7799e7052b18585fb313`. PR: https://forgejo.creatidy.com/Creatidy/creatidy-kernel/pulls/20 -> `develop`; only `.kilo/command/deliver-issue.md` and `.kilo/command/review-pr.md` changed. Issue #6 / PR #18 implementation untouched. Validation at this HEAD: `make check` passed (152 tests and format/lint/type/import/secret/diff gates); `make package-check` passed; Forgejo CI run #1950 succeeded (https://forgejo.creatidy.com/Creatidy/creatidy-kernel/actions/runs/34). Dependencies/tooling unchanged, so `make audit` was not rerun. Fresh independent full review #604 (https://forgejo.creatidy.com/Creatidy/creatidy-kernel/pulls/20#issuecomment-11742), exact frozen HEAD above/base `059482d045bd8e772005c9fbc1a9b89ce64ce26f`: routed `repository_review` L4, minimum reasoning/coding/tool_use 5/5/5 with required tool use/reasoning mode; Router selected `zai/glm-5.3/max` (catalog v4, profile policy v8, degraded=false), dispatched `GLM-5.3/zai-coding-plan/max` under documented provider adapter, Agent Manager resolution verified, fresh session `ses_f2315fdc8ffeGowH1UpmCBG9Jp` / request `am-1790412718534-aykyif`. `substantive_verdict = APPROVE`; blocking findings = 0; `forgejo_review_state = COMMENT`; `platform_approval_recorded = false`. Forgejo rejected formal `APPROVED` with `approve your own pull is not allowed` because both PR author and configured reviewer account are `kilo`; the reviewer preserved substantive APPROVE in `### Overall Recommendation`. The issue's owner authorization permits this substantive verdict for this corrective PR. No unresolved blocker; PR remains open and unmerged; issue remains open until owner integration.