[P2][workflow] Revalidate dependency evidence before loop terminal outcomes #28
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Goal
Apply evidence-based dependency-chain tracing and nonterminal recovery narration to Console's owner-authorized
/loop, retaining its existing re-selection behavior.Why
Console already revalidates an untouched selected issue before delivery and returns a proven gate to fresh full
SELECT(#23). Its currentdeveloprules still do not trace dependency edges backward to the earliest executable predecessor, explicitly classify unknown evidence asUNVERIFIED, or state that recovery progress narration is nonterminal. Scarcity Router issue #202 and merged PR #203 provide the verified precedent.Scope
Adapt
.kilo/command/loop.md,.kilo/rules/10-task-system.md, relevant bounded-recovery guidance, andtests/workflow-contract.test.mjs. Evaluate only canonical Console issues and the producer/contract evidence explicitly required by them.Acceptance Criteria
WAITor terminal decision (BLOCKED,STOP_AND_ASK,QUEUE_EMPTY), refresh canonical dependency/producer-contract evidence and trace explicit dependency chains backward to the earliest executable predecessor. One gated issue cannot block unrelated eligible Console work.UNVERIFIED, never proof of readiness or a verified gate/blocker. Preserve the evidence gap; do not claimQUEUE_EMPTYfrom unknown data.#23re-selection and started-delivery history, explicit-/loopfull-queue selection, standalone issue/PR scope, reviewer independence, review counters, Console producer/browser/security boundaries, checks, and merge authority.Constraints
Console development workflow only; no UI/product schema, producer, live integration, private credential, cross-repository feature, or Router-specific model/security policy changes. Do not weaken existing licensing, privacy, independent-review, validation, counter, or merge gates.
Links
Implemented the workflow-contract change in PR #29: #29 (
issue-28-dependency-evidence). It adds final/WAIT dependency evidence checkpoints, recursive Console dependency tracing, explicitUNVERIFIEDrecovery for incomplete evidence, preservation of independent eligible issues, and nonterminal recovery narration, with offline semantic contract tests.Validation: focused workflow tests PASS (19);
make checkPASS (24 tests across 3 files plus formatting, Markdown, links, secretlint, TypeScript, and temporary artifact/license checks);git diff --checkPASS.Base
3402433d84d741c02797e63b2ddc0ca7687c8a06; head8787081f48f85fbe84fa0e42fd39597928605f6f. PR targetsdevelop; issue remains open and PR unmerged. Tests guard workflow text/contracts and do not establish live/loopruntime, permission enforcement, or producer integration.PR #29 now includes remediation commit
cb6cb181f60490a4e75d195ad096503b31aeda2ffor a whole-PR review finding: the synthetic dependency traversal now tracks the active recursion path, correctly accepts a shared dependency in a converging DAG, and still detects an actual cycle asUNVERIFIED.Focused workflow contract tests (19) and full
make check(24 tests/3 files plus all repository lint/type/build/license gates) pass after the correction. Review ordinal 1 returnedREQUEST_CHANGESon the superseded HEAD; its finding was remediated. Current PR head:cb6cb181f60490a4e75d195ad096503b31aeda2f; base remains3402433d84d741c02797e63b2ddc0ca7687c8a06. A fresh whole-PR review is pending.PR #29 has completed the native whole-PR review workflow. Ordinal 1 returned
REQUEST_CHANGESfor a test-model edge case; remediation commitcb6cb181f60490a4e75d195ad096503b31aeda2fadded converging-DAG and actual-cycle regression coverage. Fresh review ordinal 2 returned exact-HEAD/baseAPPROVEwith no findings. Exact-head CI run 23 succeeded; currentmake checkand clean-checkout verification pass.Terminal standalone finish result:
READY_TO_MERGE. PR #29 remains open/unmerged and issue #28 remains open; this invocation does not authorize merge or issue closure. Current base3402433d84d741c02797e63b2ddc0ca7687c8a06, headcb6cb181f60490a4e75d195ad096503b31aeda2f.