Creatidy/model-intelligence
5
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Preserve native PR review automation in a single checkout #6

Merged
adrian.tkacz merged 3 commits from issue-5-native-review into develop 2026-10-04 00:41:41 +00:00
Conversation 2 Commits 3 Files changed 10 +290 -70
kilo commented 2026-10-03 22:57:38 +00:00
Member
Copy link

Refs #5

Phase A Scope

Canonical develop was inspected through normal Git at a1c3b8b12c: it has no pr-reviewer agent or finish-pr command, and no history for those paths. This PR independently preserves issue #5 automation before any M0-01R work. It is not a replacement for PR #4's domain experiment.

Reused only the seven-file workflow delta from ef0aa62a22 using cherry-pick --no-commit, then incorporated the owner's no-worktree decision across all ten applicable workflow Markdown files. No source, domain tests, README, packaging, Makefile or dependencies differ from develop; no failed temporal implementation is included.

Workflow

  • One normal checkout and ordinary issue/PR branches. No git worktree or alternate checkout management unless the owner explicitly re-enables it. Safe switching only; never stash/reset unrelated work.
  • Parent freezes HEAD/base on the current clean PR branch and prepares its offline locked environment. Reviewer inspects frozen Git objects/current branch read-only in the SAME checkout. Parent cannot edit or switch while the reviewer is active.
  • Newly spawned foreground native pr-reviewer task, isolated context, verified openai/gpt-6.1-sol / high. Deny-by-default permissions disallow edits/writes, Git/Forgejo mutations, delegation and parent-context access; allow repository/MCP reads and inspected safe validation.
  • Stable JSON task result is the direct handoff. /finish-pr autonomously reviews, remediates accepted-scope findings, validates, commits as Adrian, pushes the same PR branch and starts a fresh whole-PR reviewer. At most three remediation rounds after initial review; READY_TO_MERGE, STOP_REVISE, genuine OWNER_DECISION_NEEDED or precise finite BLOCKED. Never merge/release/deploy/promote main.
  • /review-pr uses the same contract; implement-issue continues through the bounded native finish workflow. Removed obsolete manual-session and worktree instructions and the failed-proof-specific focused-test permission. No external orchestration or new protocol/state machine.

Frozen Implementation Delivery

  • Base/merge base: a1c3b8b12c.
  • Initial HEAD: 0406bd5ef5.
  • Branch: issue-5-native-review in /home/adrian/workspace/model-intelligence, the existing normal checkout.
  • Normal commit/push succeeded as Adrian Tkacz adrian.tkacz@creatidy.com; Git/MCP remote checks and clean status confirmed.
  • Exact changed files: AGENTS.md; .kilo/agents/pr-reviewer.md; .kilo/command/finish-pr.md; .kilo/command/review-pr.md; .kilo/command/implement-issue.md; .kilo/rules/10-task-system.md; .kilo/rules/20-forgejo-mcp.md; .kilo/rules/30-implementation-discipline.md; .kilo/rules/40-local-search.md; .kilo/rules/validation.md.

Validation

  • Installed Kilo 7.8.3 models openai confirms openai/gpt-6.1-sol; native debug config parses/discovers all three commands and agent/frontmatter.
  • Native debug agent pr-reviewer and assertions over its resolved tool/permission rules: PASS, including denied edits/writes/delegation/Git mutation/Forgejo writes/additional checkout access and allowed safe checks/MCP reads.
  • UV_OFFLINE=1 make check: PASS, 2 unchanged bootstrap tests, Ruff lint/format, basedpyright 0 errors/warnings, locked sync, staged/unstaged whitespace.
  • Complete base delta inspected; git diff --check PASS; local progress/runtime artifacts excluded.
  • Extension inline frontmatter hook reported 'No context found for instance'; independent installed native parsing succeeds, so no YAML/discovery blocker is asserted.

Native /finish-pr will now review this workflow PR automatically. This description is implementation evidence, not approval. Human integration is required: even READY_TO_MERGE stops Phase A; M0-01R is not created or started until this PR actually integrates into canonical develop.

PR #4 / issue #3 remain STOP_REVISE evidence at experimental HEAD 303f5fe118, open/unmerged and untouched. No successor domain issue is created in Phase A.

Refs #5 ## Phase A Scope Canonical develop was inspected through normal Git at a1c3b8b12c08e54743612a9b74873da42251ae70: it has no pr-reviewer agent or finish-pr command, and no history for those paths. This PR independently preserves issue #5 automation before any M0-01R work. It is not a replacement for PR #4's domain experiment. Reused only the seven-file workflow delta from ef0aa62a224f083e6fda8da354f2d5fda07e8661 using cherry-pick --no-commit, then incorporated the owner's no-worktree decision across all ten applicable workflow Markdown files. No source, domain tests, README, packaging, Makefile or dependencies differ from develop; no failed temporal implementation is included. ## Workflow - One normal checkout and ordinary issue/PR branches. No git worktree or alternate checkout management unless the owner explicitly re-enables it. Safe switching only; never stash/reset unrelated work. - Parent freezes HEAD/base on the current clean PR branch and prepares its offline locked environment. Reviewer inspects frozen Git objects/current branch read-only in the SAME checkout. Parent cannot edit or switch while the reviewer is active. - Newly spawned foreground native pr-reviewer task, isolated context, verified openai/gpt-6.1-sol / high. Deny-by-default permissions disallow edits/writes, Git/Forgejo mutations, delegation and parent-context access; allow repository/MCP reads and inspected safe validation. - Stable JSON task result is the direct handoff. /finish-pr autonomously reviews, remediates accepted-scope findings, validates, commits as Adrian, pushes the same PR branch and starts a fresh whole-PR reviewer. At most three remediation rounds after initial review; READY_TO_MERGE, STOP_REVISE, genuine OWNER_DECISION_NEEDED or precise finite BLOCKED. Never merge/release/deploy/promote main. - /review-pr uses the same contract; implement-issue continues through the bounded native finish workflow. Removed obsolete manual-session and worktree instructions and the failed-proof-specific focused-test permission. No external orchestration or new protocol/state machine. ## Frozen Implementation Delivery - Base/merge base: a1c3b8b12c08e54743612a9b74873da42251ae70. - Initial HEAD: 0406bd5ef5179237caee13e9a71e7babbc9cdea9. - Branch: issue-5-native-review in /home/adrian/workspace/model-intelligence, the existing normal checkout. - Normal commit/push succeeded as Adrian Tkacz <adrian.tkacz@creatidy.com>; Git/MCP remote checks and clean status confirmed. - Exact changed files: AGENTS.md; .kilo/agents/pr-reviewer.md; .kilo/command/finish-pr.md; .kilo/command/review-pr.md; .kilo/command/implement-issue.md; .kilo/rules/10-task-system.md; .kilo/rules/20-forgejo-mcp.md; .kilo/rules/30-implementation-discipline.md; .kilo/rules/40-local-search.md; .kilo/rules/validation.md. ## Validation - Installed Kilo 7.8.3 models openai confirms openai/gpt-6.1-sol; native debug config parses/discovers all three commands and agent/frontmatter. - Native debug agent pr-reviewer and assertions over its resolved tool/permission rules: PASS, including denied edits/writes/delegation/Git mutation/Forgejo writes/additional checkout access and allowed safe checks/MCP reads. - UV_OFFLINE=1 make check: PASS, 2 unchanged bootstrap tests, Ruff lint/format, basedpyright 0 errors/warnings, locked sync, staged/unstaged whitespace. - Complete base delta inspected; git diff --check PASS; local progress/runtime artifacts excluded. - Extension inline frontmatter hook reported 'No context found for instance'; independent installed native parsing succeeds, so no YAML/discovery blocker is asserted. Native /finish-pr will now review this workflow PR automatically. This description is implementation evidence, not approval. Human integration is required: even READY_TO_MERGE stops Phase A; M0-01R is not created or started until this PR actually integrates into canonical develop. PR #4 / issue #3 remain STOP_REVISE evidence at experimental HEAD 303f5fe118a592f3cf5e7ea47c5955625850ea28, open/unmerged and untouched. No successor domain issue is created in Phase A.
kilo commented 2026-10-03 23:55:51 +00:00
Author
Member
Copy link

READY_TO_MERGE / APPROVE at exact HEAD 9def2da405, base/merge-base a1c3b8b12c.

Bounded operation completed two remediation rounds, automatically consuming native foreground reviewer JSON without owner message-copying. Whole-PR reviews: 0406bd5ef5 COMMENT; 18acc3d59d REQUEST_CHANGES; final 9def2da405 APPROVE with no findings. Each reviewer was newly spawned and used verified openai/gpt-6.1-sol/high in the same clean normal checkout; final task ses_efbd71ed4ffeJtriPGiPdpiW66 exact JSON fields/SHAs/model were verified.

Remediations corrected native slash normalization and restricted reviewer Git transport to canonical HTTPS develop/metadata-head queries, denying executable override options and local/alternate/helper transports. Safe negative permission regression checks passed without executing a helper; final reviewer independently performed the permitted canonical Git query and full repository gate.

UV_OFFLINE=1 make check and frozen-delta git diff --check PASS: locked synchronization, Ruff lint/format, basedpyright zero errors/warnings and 2 unchanged bootstrap tests. Native YAML/discovery/resolved-permission checks PASS. Final local status clean and MCP/canonical refs unchanged/open/unmerged develop target. Limitations: bootstrap tests do not cover all Markdown orchestration or exhaustive permission escapes; those checks used native inspection and controlled permission regressions rather than executing unsafe commands.

This is workflow-only Phase A: ten Markdown files, no failed PR #4 domain code, no production/test/dependency/packaging changes, no git worktree operations or alternate checkout management. PR #4 remains STOP_REVISE and unmerged. No formal review publication or merge occurred; this comment reports the native result, not orchestration state. Phase B/M0-01R is not created or started until human integration into canonical develop.

READY_TO_MERGE / APPROVE at exact HEAD 9def2da405773cde833052fd5030dd624f26623c, base/merge-base a1c3b8b12c08e54743612a9b74873da42251ae70. Bounded operation completed two remediation rounds, automatically consuming native foreground reviewer JSON without owner message-copying. Whole-PR reviews: 0406bd5ef5179237caee13e9a71e7babbc9cdea9 COMMENT; 18acc3d59d238667c062be71a1a3a2f5e95410fc REQUEST_CHANGES; final 9def2da405773cde833052fd5030dd624f26623c APPROVE with no findings. Each reviewer was newly spawned and used verified openai/gpt-6.1-sol/high in the same clean normal checkout; final task ses_efbd71ed4ffeJtriPGiPdpiW66 exact JSON fields/SHAs/model were verified. Remediations corrected native slash normalization and restricted reviewer Git transport to canonical HTTPS develop/metadata-head queries, denying executable override options and local/alternate/helper transports. Safe negative permission regression checks passed without executing a helper; final reviewer independently performed the permitted canonical Git query and full repository gate. UV_OFFLINE=1 make check and frozen-delta git diff --check PASS: locked synchronization, Ruff lint/format, basedpyright zero errors/warnings and 2 unchanged bootstrap tests. Native YAML/discovery/resolved-permission checks PASS. Final local status clean and MCP/canonical refs unchanged/open/unmerged develop target. Limitations: bootstrap tests do not cover all Markdown orchestration or exhaustive permission escapes; those checks used native inspection and controlled permission regressions rather than executing unsafe commands. This is workflow-only Phase A: ten Markdown files, no failed PR #4 domain code, no production/test/dependency/packaging changes, no git worktree operations or alternate checkout management. PR #4 remains STOP_REVISE and unmerged. No formal review publication or merge occurred; this comment reports the native result, not orchestration state. Phase B/M0-01R is not created or started until human integration into canonical develop.
adrian.tkacz deleted branch issue-5-native-review 2026-10-04 00:41:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
adrian.tkacz
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Creatidy/model-intelligence!6
No description provided.