Migrate development commands to the Model Intelligence owner-authorized loop workflow #64

New issue

Closed

opened 2026-10-05 08:53:20 +00:00 by kilo · 1 comment

kilo commented

2026-10-05 08:53:20 +00:00

Member

Goal

Replace the Kernel development command system with the current local Model Intelligence repository's coherent owner-authorized /loop workflow, without redesigning the product model.

Why

The owner explicitly mandates this migration. Existing single-issue delivery commands and Scarcity Router development-review dispatch rules conflict with the requested same-checkout native-review loop. Narrow canonical duplicate search found no matching Kernel migration issue.

Scope

Inspect the actual current files in /home/adrian/workspace/model-intelligence, inventory all Kernel commands and replace them with implement-issue, review-pr, finish-pr and loop.
Synchronize AGENTS.md, task/Forgejo/implementation/search/validation rules, the isolated read-only pr-reviewer definition, discovery documentation and workflow-contract tests.
Adapt only repository identity, actual paths, existing authoritative validation gates and accepted Kernel architecture boundaries.
Preserve standalone owner selection and no-merge authority; only explicit /loop authorizes autonomous selection, exact-approved PR merge to develop and verified completion/continuation.

Out of scope: product runtime/model redesign; executing the new loop for this migration; other repositories; worktrees/alternate checkouts; direct develop pushes; main, release or deployment.

Acceptance Criteria

Exactly four commands: /implement-issue, /review-pr, /finish-pr, /loop, with no duplicate legacy delivery controller.
Same primary orchestrator, one normal checkout, one mutator; fresh isolated foreground read-only whole-PR reviewers, never implementation self-approval.
Fresh paginated issue-only selection, exact case-insensitive invalid/wontfix/duplicate exclusion, explicit gates and deterministic priority/required-order/created_at/number ordering; historical PRs never restart authority.
Pre-merge excluded issues return safely to SELECT nonterminally without merge/completion.
Excluded local delivery ledger reserves review ordinals before dispatch, survives reentry/session/model/phase changes and enforces ten whole-PR reviews with no review eleven.
Only explicit /loop can use canonical Forgejo PR merge into develop after exact HEAD/base/currentness/validation/authority checks; issue closure follows verified merged ancestry and integrated acceptance.
Genuine owner decisions stop the entire loop with STOP_AND_ASK and evidence/options; routine reversible scoped engineering proceeds autonomously.
No Scarcity Router use for model selection, execution, orchestration, telemetry or operation of the migrated development loop. Existing product Router boundaries remain unchanged.
Port current Model Intelligence workflow-contract tests and run focused tests, make check and make package-check; run make audit if relevant.
One normal branch from current canonical develop, one PR to develop, current pre-migration independent delivery review. Leave unmerged absent existing owner merge authority.

Constraints

Use the owner's complete 2026-10-05 migration request and current local Model Intelligence contents as workflow authority. Keep adapters -> ports -> core and accepted architecture/ADRs unchanged except conflicting development-authority wording. Preserve unrelated owner work and existing excluded ledger history. No private state/secrets. No new loop authority may authorize its own migration delivery. Current pre-migration delivery bound is ten remediation cycles, not the new ten-review bound.

Links

Canonical repository: https://forgejo.creatidy.com/Creatidy/creatidy-kernel
Authoritative workflow reference: /home/adrian/workspace/model-intelligence (current local files)
Kernel architecture: docs/architecture/successor.md and docs/adr/0007-shared-harness-routing-observability.md
Owner mandate: explicit workflow migration request in this implementation session, 2026-10-05

## Goal Replace the Kernel development command system with the current local Model Intelligence repository's coherent owner-authorized /loop workflow, without redesigning the product model. ## Why The owner explicitly mandates this migration. Existing single-issue delivery commands and Scarcity Router development-review dispatch rules conflict with the requested same-checkout native-review loop. Narrow canonical duplicate search found no matching Kernel migration issue. ## Scope - Inspect the actual current files in /home/adrian/workspace/model-intelligence, inventory all Kernel commands and replace them with implement-issue, review-pr, finish-pr and loop. - Synchronize AGENTS.md, task/Forgejo/implementation/search/validation rules, the isolated read-only pr-reviewer definition, discovery documentation and workflow-contract tests. - Adapt only repository identity, actual paths, existing authoritative validation gates and accepted Kernel architecture boundaries. - Preserve standalone owner selection and no-merge authority; only explicit /loop authorizes autonomous selection, exact-approved PR merge to develop and verified completion/continuation. Out of scope: product runtime/model redesign; executing the new loop for this migration; other repositories; worktrees/alternate checkouts; direct develop pushes; main, release or deployment. ## Acceptance Criteria - [ ] Exactly four commands: /implement-issue, /review-pr, /finish-pr, /loop, with no duplicate legacy delivery controller. - [ ] Same primary orchestrator, one normal checkout, one mutator; fresh isolated foreground read-only whole-PR reviewers, never implementation self-approval. - [ ] Fresh paginated issue-only selection, exact case-insensitive invalid/wontfix/duplicate exclusion, explicit gates and deterministic priority/required-order/created_at/number ordering; historical PRs never restart authority. - [ ] Pre-merge excluded issues return safely to SELECT nonterminally without merge/completion. - [ ] Excluded local delivery ledger reserves review ordinals before dispatch, survives reentry/session/model/phase changes and enforces ten whole-PR reviews with no review eleven. - [ ] Only explicit /loop can use canonical Forgejo PR merge into develop after exact HEAD/base/currentness/validation/authority checks; issue closure follows verified merged ancestry and integrated acceptance. - [ ] Genuine owner decisions stop the entire loop with STOP_AND_ASK and evidence/options; routine reversible scoped engineering proceeds autonomously. - [ ] No Scarcity Router use for model selection, execution, orchestration, telemetry or operation of the migrated development loop. Existing product Router boundaries remain unchanged. - [ ] Port current Model Intelligence workflow-contract tests and run focused tests, make check and make package-check; run make audit if relevant. - [ ] One normal branch from current canonical develop, one PR to develop, current pre-migration independent delivery review. Leave unmerged absent existing owner merge authority. ## Constraints Use the owner's complete 2026-10-05 migration request and current local Model Intelligence contents as workflow authority. Keep adapters -> ports -> core and accepted architecture/ADRs unchanged except conflicting development-authority wording. Preserve unrelated owner work and existing excluded ledger history. No private state/secrets. No new loop authority may authorize its own migration delivery. Current pre-migration delivery bound is ten remediation cycles, not the new ten-review bound. ## Links - Canonical repository: https://forgejo.creatidy.com/Creatidy/creatidy-kernel - Authoritative workflow reference: /home/adrian/workspace/model-intelligence (current local files) - Kernel architecture: docs/architecture/successor.md and docs/adr/0007-shared-harness-routing-observability.md - Owner mandate: explicit workflow migration request in this implementation session, 2026-10-05

adrian.tkacz referenced this issue from a commit

2026-10-05 09:30:32 +00:00

chore: migrate development commands to the MI loop workflow (#64)

kilo referenced this issue

2026-10-05 09:31:34 +00:00

chore: migrate development commands to the Model Intelligence loop workflow (#64) #65

adrian.tkacz referenced this issue from a commit

2026-10-05 09:36:05 +00:00

chore: preserve source command wording in workflow migration (#64)

kilo commented

2026-10-05 09:38:41 +00:00

Author

Member

Migration Delivery Ledger

PR: #65
Branch: issue-64-model-intelligence-workflow
Recorded base: c1ad28a517
Final HEAD: 1f9172b7cc
Commits: c1c3ce6 (migration), 1f9172b (preserve source wording). Both authored/committed as Adrian Tkacz adrian.tkacz@creatidy.com.

Before: create-follow-up-issue, deliver-issue, implement-issue, review-pr.
After: implement-issue, review-pr, finish-pr, loop. No duplicate legacy controller remains. Authorized follow-up quality/deduplication/trigger safeguards stay in task rules; no automatic issue registration.

Current local Model Intelligence reference files were inspected and copied/adapted; their checkout HEAD is 013cbb43e11d7f698d359db5a456d26d8075e34e and the inspected local contents match that HEAD. Identity/architecture/gate/permission-command adaptations and attribution are documented in PR/NOTICE/reuse record. Reviewer isolation/model/denials and source loop semantics preserved. No product runtime/dependency/lock changes.

Final validation:

uv run --locked pytest tests/test_workflow_contract.py: PASS, 11 tests, 32 subtests.
uv run --locked ruff check tests/test_workflow_contract.py: PASS.
uv run --locked basedpyright tests/test_workflow_contract.py: PASS, zero errors/warnings.
make check, rerun after final edits: PASS, 977 tests, 32 subtests; format/lint/type/import/secrets/whitespace gates passed.
make package-check, rerun after final edits: PASS, reproducible archives, isolated install and CLI replay/export.
make audit: PASS, no known vulnerabilities.
Canonical Forgejo CI #2210 on final HEAD: success, https://forgejo.creatidy.com/Creatidy/creatidy-kernel/actions/runs/84
Fresh Git/MCP confirms exact PR HEAD/base, open/unmerged develop target, base ancestry and clean same checkout.

Pre-Migration Review Status

Terminal: REVIEW_INFRASTRUCTURE_BLOCKED.
Independent substantive verdict: NOT_RUN; no APPROVE obtained and no valid review dispatch claimed.
max_remediation_cycles=10; remediation_used=0; valid_completed_review_count=0.
The pre-migration /deliver-issue contract requires a fresh Scarcity Router repository_review selection and Router-eligible Agent Manager dispatch with verified model resolution. This session exposes no Router selection tool. A non-routed reviewer or the newly copied /finish-pr semantics cannot substitute under the owner's migration instructions. Missing capability has no corrected-input retry; it was not bypassed by REST, private state or self-review.
The native CLI discovery probe also failed: kilo debug agent pr-reviewer -> kilo: command not found. Native agent/runtime discovery and actual loop execution are unverified; a workspace reload may be required after integration. Local ledger .task_progress.md remains Git-locally excluded with earlier history preserved.

No Scarcity Router calls, worktrees/alternate checkouts, external-repository mutations, unrelated stash/reset, direct develop pushes, main changes, releases or deployments. New /loop was never invoked. Leave #64 open and PR #65 unmerged; implementation/validation is complete but delivery acceptance awaits a valid pre-migration independent review.

## Migration Delivery Ledger PR: https://forgejo.creatidy.com/Creatidy/creatidy-kernel/pulls/65 Branch: issue-64-model-intelligence-workflow Recorded base: c1ad28a517a80ea847f78da9a097138a9aea494b Final HEAD: 1f9172b7cceef50bd1c5f3caffa8d30c0f07fcfc Commits: c1c3ce6 (migration), 1f9172b (preserve source wording). Both authored/committed as Adrian Tkacz <adrian.tkacz@creatidy.com>. Before: create-follow-up-issue, deliver-issue, implement-issue, review-pr. After: implement-issue, review-pr, finish-pr, loop. No duplicate legacy controller remains. Authorized follow-up quality/deduplication/trigger safeguards stay in task rules; no automatic issue registration. Current local Model Intelligence reference files were inspected and copied/adapted; their checkout HEAD is 013cbb43e11d7f698d359db5a456d26d8075e34e and the inspected local contents match that HEAD. Identity/architecture/gate/permission-command adaptations and attribution are documented in PR/NOTICE/reuse record. Reviewer isolation/model/denials and source loop semantics preserved. No product runtime/dependency/lock changes. Final validation: - uv run --locked pytest tests/test_workflow_contract.py: PASS, 11 tests, 32 subtests. - uv run --locked ruff check tests/test_workflow_contract.py: PASS. - uv run --locked basedpyright tests/test_workflow_contract.py: PASS, zero errors/warnings. - make check, rerun after final edits: PASS, 977 tests, 32 subtests; format/lint/type/import/secrets/whitespace gates passed. - make package-check, rerun after final edits: PASS, reproducible archives, isolated install and CLI replay/export. - make audit: PASS, no known vulnerabilities. - Canonical Forgejo CI #2210 on final HEAD: success, https://forgejo.creatidy.com/Creatidy/creatidy-kernel/actions/runs/84 - Fresh Git/MCP confirms exact PR HEAD/base, open/unmerged develop target, base ancestry and clean same checkout. ## Pre-Migration Review Status Terminal: REVIEW_INFRASTRUCTURE_BLOCKED. Independent substantive verdict: NOT_RUN; no APPROVE obtained and no valid review dispatch claimed. max_remediation_cycles=10; remediation_used=0; valid_completed_review_count=0. The pre-migration /deliver-issue contract requires a fresh Scarcity Router repository_review selection and Router-eligible Agent Manager dispatch with verified model resolution. This session exposes no Router selection tool. A non-routed reviewer or the newly copied /finish-pr semantics cannot substitute under the owner's migration instructions. Missing capability has no corrected-input retry; it was not bypassed by REST, private state or self-review. The native CLI discovery probe also failed: kilo debug agent pr-reviewer -> kilo: command not found. Native agent/runtime discovery and actual loop execution are unverified; a workspace reload may be required after integration. Local ledger .task_progress.md remains Git-locally excluded with earlier history preserved. No Scarcity Router calls, worktrees/alternate checkouts, external-repository mutations, unrelated stash/reset, direct develop pushes, main changes, releases or deployments. New /loop was never invoked. Leave #64 open and PR #65 unmerged; implementation/validation is complete but delivery acceptance awaits a valid pre-migration independent review.

adrian.tkacz referenced this issue from a commit

2026-10-05 10:18:18 +00:00

Merge pull request 'chore: migrate development commands to the Model Intelligence loop workflow (#64)' (#65) from issue-64-model-intelligence-workflow into develop

adrian.tkacz closed this issue

2026-10-05 10:19:19 +00:00