chore: migrate development commands to the Model Intelligence loop workflow (#64) #65

Merged

adrian.tkacz merged 2 commits from issue-64-model-intelligence-workflow into develop

2026-10-05 10:18:17 +00:00

kilo commented

2026-10-05 09:31:34 +00:00

Member

Scope

Refs #64. Replaces the complete development command system with the CURRENT LOCAL Model Intelligence workflow, without redesigning Kernel product behavior.

Repository: Creatidy/creatidy-kernel
Base: c1ad28a517
Final HEAD: 1f9172b7cc
Branch: issue-64-model-intelligence-workflow
Commits: c1c3ce6 (migration), 1f9172b (preserve exact source wording).

Command Inventory

Before: /create-follow-up-issue, /deliver-issue, /implement-issue, /review-pr.
After: /implement-issue, /review-pr, /finish-pr, /loop.
Delivery is represented once by implement/finish. Follow-up issue quality (durable, distinct, actionable, deduplicated, verifiable criteria and triggering links) remains in task rules under explicit registration authorization, not an obsolete command or speculative queue.

Source And Exact Deviations

All requested live reference files were read at /home/adrian/workspace/model-intelligence. Current local reference HEAD: 013cbb43e11d7f698d359db5a456d26d8075e34e. Git confirms the inspected files match that HEAD; actual local contents were used, not remembered text or an older revision. Source repository was not mutated. Apache-2.0 license/attribution and adaptations are recorded in NOTICE and the existing reuse record.

Deviations are limited to Kernel repository identity/URLs/product names and external exclusion list; accepted Kernel architecture paths/boundaries and issue-quality safeguards; existing make check AND make package-check gates plus conditional make audit; exact pytest/import-linter/offline package-check reviewer commands; M0 -> A0 proof wording; required modification notices; adapted frozen test hashes with non-security SHA-1 and scanner annotations; one added inventory/gate/permission test. The source's Adrian-selected description and missing-native-review wording are retained. Reviewer model/variant, all existing denial patterns and isolation instructions are preserved. No runtime product code, dependencies or lockfile changes.

Acceptance Evidence

Only explicit owner /loop delegates autonomous canonical issue selection and approved PR integration. Primary invocation is the sole orchestrator; one normal checkout and one mutator, no worktrees/alternate checkouts/stash/reset of unrelated work.
Fully paginated fresh issue queue; only exact case-insensitive invalid/wontfix/duplicate exclusions; explicit prerequisites/owner decisions; deterministic priority, required ordering, created_at and issue-number tie-break. Issues, not PRs, plan work; historical PRs do not authorize restart.
Pre-merge excluded selected issue returns safely to SELECT without merging/closing it or producing an exclusion-only terminal blocker.
Fresh foreground isolated read-only whole-PR pr-reviewer, exact HEAD/base, no implementation self-approval/resumed reviewer, no edits or branch switches while reviewing.
Excluded local .task_progress.md reserves review ordinals before dispatch; ten whole-PR reviews including initial/COMMENT/invalidated/retries, persistent across finish/phase/task/model/session changes, no review eleven.
Only /loop may invoke canonical Forgejo PR merge into develop after exact approval/currentness/cleanliness/validation/issue-authority gates; closure follows verified merged ancestry and integrated acceptance, then SELECT restarts.
Genuine owner decisions terminate the entire loop with STOP_AND_ASK; no speculative issues, cross-repository mutation, direct develop push, main, release or deployment.
No Scarcity Router development model selection, execution, orchestration, telemetry or operation. Accepted product Router ownership remains unchanged.

Files

Replaced: .kilo/command/implement-issue.md and review-pr.md; AGENTS.md and task/Forgejo/implementation/search/validation rules.
Added: finish-pr.md, loop.md, .kilo/agents/pr-reviewer.md, tests/test_workflow_contract.py.
Deleted: deliver-issue.md and create-follow-up-issue.md.
Adapted supporting files: .gitignore agent allowlisting, README, CONTRIBUTING, narrow development references in target/successor/ADR 0007, NOTICE and reuse provenance.

Final Validation

uv run --locked pytest tests/test_workflow_contract.py: PASS, 11 tests and 32 subtests.
uv run --locked ruff check tests/test_workflow_contract.py: PASS.
uv run --locked basedpyright tests/test_workflow_contract.py: PASS, zero errors/warnings.
make check rerun after final source-wording/hash changes: PASS, 977 tests and 32 subtests; locked tooling, formatting/lint, typing, import boundaries, secret scanning and whitespace passed.
make package-check rerun after final changes: PASS, reproducible wheel/sdist, isolated install and CLI replay/export.
make audit: PASS, no known vulnerabilities; audited unchanged lock.
git diff --cached --check: PASS; exact base ancestry and clean checkout verified. Both commits use Adrian Tkacz adrian.tkacz@creatidy.com.

Review And Delivery Limitations

Terminal status: REVIEW_INFRASTRUCTURE_BLOCKED under the PRE-MIGRATION /deliver-issue contract. Independent delivery review: NOT_RUN, not APPROVE. Valid completed reviews: 0; remediation_used: 0/10. The old contract requires a fresh Scarcity Router repository_review selection and Router-eligible Agent Manager dispatch with verified resolution. No Router selection tool is exposed here. That requirement was not bypassed using the newly copied native-review rules or parent self-review.
The migration's new /loop was not invoked and cannot authorize its own integration. No merge authority is granted by this request: PR remains unmerged and #64 remains open. Local excluded ledger is .task_progress.md; canonical issue update records delivery evidence.
CLI discovery check failed because kilo is not installed on PATH. Native reviewer discovery/execution and end-to-end loop operation are unverified; workspace reload may be required after integration. Contract tests are offline textual consistency guards, not runtime/merge proof. Final canonical CI status is reported separately when observed.

## Scope Refs #64. Replaces the complete development command system with the CURRENT LOCAL Model Intelligence workflow, without redesigning Kernel product behavior. Repository: Creatidy/creatidy-kernel Base: c1ad28a517a80ea847f78da9a097138a9aea494b Final HEAD: 1f9172b7cceef50bd1c5f3caffa8d30c0f07fcfc Branch: issue-64-model-intelligence-workflow Commits: c1c3ce6 (migration), 1f9172b (preserve exact source wording). ## Command Inventory Before: /create-follow-up-issue, /deliver-issue, /implement-issue, /review-pr. After: /implement-issue, /review-pr, /finish-pr, /loop. Delivery is represented once by implement/finish. Follow-up issue quality (durable, distinct, actionable, deduplicated, verifiable criteria and triggering links) remains in task rules under explicit registration authorization, not an obsolete command or speculative queue. ## Source And Exact Deviations All requested live reference files were read at /home/adrian/workspace/model-intelligence. Current local reference HEAD: 013cbb43e11d7f698d359db5a456d26d8075e34e. Git confirms the inspected files match that HEAD; actual local contents were used, not remembered text or an older revision. Source repository was not mutated. Apache-2.0 license/attribution and adaptations are recorded in NOTICE and the existing reuse record. Deviations are limited to Kernel repository identity/URLs/product names and external exclusion list; accepted Kernel architecture paths/boundaries and issue-quality safeguards; existing make check AND make package-check gates plus conditional make audit; exact pytest/import-linter/offline package-check reviewer commands; M0 -> A0 proof wording; required modification notices; adapted frozen test hashes with non-security SHA-1 and scanner annotations; one added inventory/gate/permission test. The source's Adrian-selected description and missing-native-review wording are retained. Reviewer model/variant, all existing denial patterns and isolation instructions are preserved. No runtime product code, dependencies or lockfile changes. ## Acceptance Evidence - Only explicit owner /loop delegates autonomous canonical issue selection and approved PR integration. Primary invocation is the sole orchestrator; one normal checkout and one mutator, no worktrees/alternate checkouts/stash/reset of unrelated work. - Fully paginated fresh issue queue; only exact case-insensitive invalid/wontfix/duplicate exclusions; explicit prerequisites/owner decisions; deterministic priority, required ordering, created_at and issue-number tie-break. Issues, not PRs, plan work; historical PRs do not authorize restart. - Pre-merge excluded selected issue returns safely to SELECT without merging/closing it or producing an exclusion-only terminal blocker. - Fresh foreground isolated read-only whole-PR pr-reviewer, exact HEAD/base, no implementation self-approval/resumed reviewer, no edits or branch switches while reviewing. - Excluded local .task_progress.md reserves review ordinals before dispatch; ten whole-PR reviews including initial/COMMENT/invalidated/retries, persistent across finish/phase/task/model/session changes, no review eleven. - Only /loop may invoke canonical Forgejo PR merge into develop after exact approval/currentness/cleanliness/validation/issue-authority gates; closure follows verified merged ancestry and integrated acceptance, then SELECT restarts. - Genuine owner decisions terminate the entire loop with STOP_AND_ASK; no speculative issues, cross-repository mutation, direct develop push, main, release or deployment. - No Scarcity Router development model selection, execution, orchestration, telemetry or operation. Accepted product Router ownership remains unchanged. ## Files Replaced: .kilo/command/implement-issue.md and review-pr.md; AGENTS.md and task/Forgejo/implementation/search/validation rules. Added: finish-pr.md, loop.md, .kilo/agents/pr-reviewer.md, tests/test_workflow_contract.py. Deleted: deliver-issue.md and create-follow-up-issue.md. Adapted supporting files: .gitignore agent allowlisting, README, CONTRIBUTING, narrow development references in target/successor/ADR 0007, NOTICE and reuse provenance. ## Final Validation - uv run --locked pytest tests/test_workflow_contract.py: PASS, 11 tests and 32 subtests. - uv run --locked ruff check tests/test_workflow_contract.py: PASS. - uv run --locked basedpyright tests/test_workflow_contract.py: PASS, zero errors/warnings. - make check rerun after final source-wording/hash changes: PASS, 977 tests and 32 subtests; locked tooling, formatting/lint, typing, import boundaries, secret scanning and whitespace passed. - make package-check rerun after final changes: PASS, reproducible wheel/sdist, isolated install and CLI replay/export. - make audit: PASS, no known vulnerabilities; audited unchanged lock. - git diff --cached --check: PASS; exact base ancestry and clean checkout verified. Both commits use Adrian Tkacz <adrian.tkacz@creatidy.com>. ## Review And Delivery Limitations Terminal status: REVIEW_INFRASTRUCTURE_BLOCKED under the PRE-MIGRATION /deliver-issue contract. Independent delivery review: NOT_RUN, not APPROVE. Valid completed reviews: 0; remediation_used: 0/10. The old contract requires a fresh Scarcity Router repository_review selection and Router-eligible Agent Manager dispatch with verified resolution. No Router selection tool is exposed here. That requirement was not bypassed using the newly copied native-review rules or parent self-review. The migration's new /loop was not invoked and cannot authorize its own integration. No merge authority is granted by this request: PR remains unmerged and #64 remains open. Local excluded ledger is .task_progress.md; canonical issue update records delivery evidence. CLI discovery check failed because kilo is not installed on PATH. Native reviewer discovery/execution and end-to-end loop operation are unverified; workspace reload may be required after integration. Contract tests are offline textual consistency guards, not runtime/merge proof. Final canonical CI status is reported separately when observed.

kilo added 1 commit

2026-10-05 09:31:34 +00:00