Creatidy/creatidy-kernel
5
0
Fork 0
Code Issues 9 Pull requests 2 Projects Releases Packages Wiki Activity Actions

feat: enforce configured whole-work budget envelopes (#56) #108

Closed
kilo wants to merge 0 commits from issue-56-work-budget-enforcement into develop
pull from: issue-56-work-budget-enforcement
merge into: Creatidy:develop
Conversation 3 Commits - Files changed - +5190 -131
kilo commented 2026-10-27 02:11:28 +00:00
Member
Copy link

Scope

Refs #56: COMPLETE active AC1-6, not a new specification-only slice. Owner-authorized normal /loop follows architecture/backlog acceptance #103. Prior PR94 remains specification-only with its consumed reviewordinal1 preserved.

Canonical PR metadata is exact current HEAD; base/merge-base e2348656238a2ff9a3244868e2beb543d86f15a5, branch issue-56-work-budget-enforcement. Normal implementation/remediation commits only, no amend/force/rewrite. Each independent result is frozen to its own HEAD/base; prior findings/results and finite counters remain in issue receipts/excluded ledger, never reset.

Functional Boundaries

  • Actual single-writer project/task reservations for counts/concurrency/retained bytes across Attempt/review/remediation/check/tool/retry/publication. Shared strict input validation; reservation != measured usage.
  • Original wall/verified CLOCK_BOOTTIME/boot identity and no renewal. Same-DB bounded clock row: pending marker BEFORE acquisition, committed high-water floors BEFORE capacity/outbox transaction; failed admission cannot erase evidence. Lost pending sample refuses fresh-process authority, with historical reads/STOP journaling available.
  • Exact Attempt/current-spec/WorkUnit/Operation/current-resource checks at claim and before effects. Named review exemption requires actual durable budgeted dispatcher; unsupported explicit review policy refuses before application effects.
  • Bounded streaming/time/poll/teardown; uncertain original command blocks reset/clean/reuse. Qualified retained live ownership, never disk PID adoption. Original bounded result/head integrity proof survives crash and cannot clean a dirty result into pass.
  • Authority-wide source-qualified usage/correction/dedupe/attribution and separate units/provenance. Estimates, partial receipts or physical settlement do not release unknown economic headroom. Unsupported strict inference refuses; uncapped basic unknown remains honest. No pricing/quota/catalogue/remote endpoint invention.
  • SQLite schema4 fences authority-bearing clock state. Verified preupgrade1/2/3backup, atomic migration and retained original records/schema3marker; complete artifact/version manifests/restores. Actual installed public schema2 reader e2348656 and schema3 reader23a28e31 refuse4 before claim/effect/record mutation. Exact historical fixtures have CI history and no persisted credentials.
  • Mid-observation/collection BudgetRefused enters common durable STOP/revocation and bounded exact original-owned cleanup, including terminal turns. Missing/failed/raising settlement proof stays cancel_uncertain across reentry; no acceptance/publication after refusal.

Installed/reopen/crash/race/exhaustion/rollback, compound integrity, downgrade/backup, receipt, byte and review-budget regressions exercise actual paths. Ordinary dispatcher106, claims/fencing59 and drivers105 remain separate; ordinary-dispatch refusal retained. One configured SQLite owner is project authority, not cross-database quota or a second workflow engine.

Latest Validation

Closed/offline locked makecheck:1600passed,85existingnative-prerequisite skips,106subtests; all static/type/import/secret/diff gatesPASS. PackagecheckPASS including two real installed older readers and backup/artifact/revocation preservation. Focused42PASS; makeauditPASS no known vulnerabilities. Parent inspected full latest delta/newfiles and committed/pushed clean exact source normally.

85skips require pinned bubblewrap/OCI setups, not positive native/realCodex/live/isolation/billing evidence. No external repository mutation, paid/live inference, owner credentials/production state/realprofiles, deployment/release/main or security weakening.

Fresh complete whole-PR review and exact currentness remain required. No review result, merge permission or issue closure is inferred from implementation/check claims; finite review history persists across reentry.

## Scope Refs #56: COMPLETE active AC1-6, not a new specification-only slice. Owner-authorized normal /loop follows architecture/backlog acceptance #103. Prior PR94 remains specification-only with its consumed reviewordinal1 preserved. Canonical PR metadata is exact current HEAD; base/merge-base `e2348656238a2ff9a3244868e2beb543d86f15a5`, branch `issue-56-work-budget-enforcement`. Normal implementation/remediation commits only, no amend/force/rewrite. Each independent result is frozen to its own HEAD/base; prior findings/results and finite counters remain in issue receipts/excluded ledger, never reset. ## Functional Boundaries - Actual single-writer project/task reservations for counts/concurrency/retained bytes across Attempt/review/remediation/check/tool/retry/publication. Shared strict input validation; reservation != measured usage. - Original wall/verified CLOCK_BOOTTIME/boot identity and no renewal. Same-DB bounded clock row: pending marker BEFORE acquisition, committed high-water floors BEFORE capacity/outbox transaction; failed admission cannot erase evidence. Lost pending sample refuses fresh-process authority, with historical reads/STOP journaling available. - Exact Attempt/current-spec/WorkUnit/Operation/current-resource checks at claim and before effects. Named review exemption requires actual durable budgeted dispatcher; unsupported explicit review policy refuses before application effects. - Bounded streaming/time/poll/teardown; uncertain original command blocks reset/clean/reuse. Qualified retained live ownership, never disk PID adoption. Original bounded result/head integrity proof survives crash and cannot clean a dirty result into pass. - Authority-wide source-qualified usage/correction/dedupe/attribution and separate units/provenance. Estimates, partial receipts or physical settlement do not release unknown economic headroom. Unsupported strict inference refuses; uncapped basic unknown remains honest. No pricing/quota/catalogue/remote endpoint invention. - SQLite **schema4** fences authority-bearing clock state. Verified preupgrade1/2/3backup, atomic migration and retained original records/schema3marker; complete artifact/version manifests/restores. Actual installed public schema2 reader e2348656 and schema3 reader23a28e31 refuse4 before claim/effect/record mutation. Exact historical fixtures have CI history and no persisted credentials. - Mid-observation/collection BudgetRefused enters common durable STOP/revocation and bounded exact original-owned cleanup, including terminal turns. Missing/failed/raising settlement proof stays cancel_uncertain across reentry; no acceptance/publication after refusal. Installed/reopen/crash/race/exhaustion/rollback, compound integrity, downgrade/backup, receipt, byte and review-budget regressions exercise actual paths. Ordinary dispatcher106, claims/fencing59 and drivers105 remain separate; ordinary-dispatch refusal retained. One configured SQLite owner is project authority, not cross-database quota or a second workflow engine. ## Latest Validation Closed/offline locked makecheck:1600passed,85existingnative-prerequisite skips,106subtests; all static/type/import/secret/diff gatesPASS. PackagecheckPASS including two real installed older readers and backup/artifact/revocation preservation. Focused42PASS; makeauditPASS no known vulnerabilities. Parent inspected full latest delta/newfiles and committed/pushed clean exact source normally. 85skips require pinned bubblewrap/OCI setups, not positive native/realCodex/live/isolation/billing evidence. No external repository mutation, paid/live inference, owner credentials/production state/realprofiles, deployment/release/main or security weakening. Fresh complete whole-PR review and exact currentness remain required. No review result, merge permission or issue closure is inferred from implementation/check claims; finite review history persists across reentry.
feat: enforce configured whole-work budget envelopes (#56)
All checks were successful
ci / check (pull_request) Successful in 2m35s
Details
18c693b166
fix: revalidate work authority and preserve uncertain commands (#56)
All checks were successful
ci / check (pull_request) Successful in 2m46s
Details
fd8fef1016
fix: preserve verification integrity and fence budget schema downgrades (#56)
All checks were successful
ci / check (pull_request) Successful in 2m51s
Details
20453149a7
fix: validate byte reservations at every admission entrance (#56)
All checks were successful
ci / check (pull_request) Successful in 3m1s
Details
4a3059277f
fix: require durable budget authority for independent review (#56)
All checks were successful
ci / check (pull_request) Successful in 2m55s
Details
23a28e31c1
fix: retain clock evidence across refusal and clean up mid-step expiry (#56)
All checks were successful
ci / check (pull_request) Successful in 3m46s
Details
5b8cf8e5a2
fix: reconcile STOP claims without adopting replacement ownership (#56)
All checks were successful
ci / check (pull_request) Successful in 3m34s
Details
19174b84d6
fix: recover original STOP targets from durable native receipts (#56)
All checks were successful
ci / check (pull_request) Successful in 3m50s
Details
7fa95a422f
fix: journal application clock reads before task authority decisions (#56)
All checks were successful
ci / check (pull_request) Successful in 3m56s
Details
d1d55d4069
kilo commented 2026-10-27 11:20:07 +00:00
Author
Member
Copy link

STOP_REVISE — Do Not Merge

Final fresh native whole-PR review ses_e82fa5df9ffergwywKo4CjS5Nj, conserved issue56ordinal10/10 (including prior PR94ordinal1), reviewed COMPLETE HEAD d1d55d406923674c847b98a30756a05e87b52d2c against base/merge-base e2348656238a2ff9a3244868e2beb543d86f15a5: REQUEST_CHANGES.

Remaining NEWP2: ports/intake.py:703–707 checks immutable work-envelope compatibility after durable approval/decision consumption and Program creation/amendment665–702. A changed expiry or incompatible project/task budget can refuse after changing the Program, stale its old binding and invalidate prior approval without returning ApprovedMeaning. Future remediation must prevalidate immutable original compatibility, keep original expiry and ensure atomic final approval/binding state; refusal regressions preserve old meaning/binding.

Both final independent required makecheck/packagecheck gates passed; latest implementation1670tests/85explicitnativeprereqskips/106subtests and packagePASS. These passes are not approval. Prior specific findings were not repeated, but atomic validation/commit boundaries remain a recurring broader pattern. Full disposition/new-versus-recurring evidence is published in linked issue #56 and the preserved excluded ledger.

No exact APPROVE; finite10/10 exhausted. Entire /loop invocation is STOP_REVISE, not QUEUE_EMPTY. PR and issue stay OPEN, branch clean/pushed, all nine normal commits/history preserved. No more product patches or review dispatches, no counter reset, self-review substitution, force/auto/direct integration or silently skipping to another issue under this invocation. New explicit STOP_REVISE restart authority is required for further delivery; already accepted architecture/backlog does not need reconfirmation.

Canonical develop stays e2348656; this PR's functional changes are NOT integrated or accepted. #103 architecture publication/delegated alignment acceptance and docPR107 integration remain complete. No external repository/production/main/release/deployment effects.

## STOP_REVISE — Do Not Merge Final fresh native whole-PR review `ses_e82fa5df9ffergwywKo4CjS5Nj`, conserved issue56ordinal10/10 (including prior PR94ordinal1), reviewed COMPLETE HEAD `d1d55d406923674c847b98a30756a05e87b52d2c` against base/merge-base `e2348656238a2ff9a3244868e2beb543d86f15a5`: **REQUEST_CHANGES**. Remaining NEWP2: `ports/intake.py:703–707` checks immutable work-envelope compatibility after durable approval/decision consumption and Program creation/amendment665–702. A changed expiry or incompatible project/task budget can refuse after changing the Program, stale its old binding and invalidate prior approval without returning ApprovedMeaning. Future remediation must prevalidate immutable original compatibility, keep original expiry and ensure atomic final approval/binding state; refusal regressions preserve old meaning/binding. Both final independent required makecheck/packagecheck gates passed; latest implementation1670tests/85explicitnativeprereqskips/106subtests and packagePASS. These passes are not approval. Prior specific findings were not repeated, but atomic validation/commit boundaries remain a recurring broader pattern. Full disposition/new-versus-recurring evidence is published in linked issue #56 and the preserved excluded ledger. **No exact APPROVE; finite10/10 exhausted. Entire /loop invocation is STOP_REVISE, not QUEUE_EMPTY.** PR and issue stay OPEN, branch clean/pushed, all nine normal commits/history preserved. No more product patches or review dispatches, no counter reset, self-review substitution, force/auto/direct integration or silently skipping to another issue under this invocation. New explicit STOP_REVISE restart authority is required for further delivery; already accepted architecture/backlog does not need reconfirmation. Canonical develop stays e2348656; this PR's functional changes are NOT integrated or accepted. #103 architecture publication/delegated alignment acceptance and docPR107 integration remain complete. No external repository/production/main/release/deployment effects.
kilo commented 2026-10-27 15:38:41 +00:00
Author
Member
Copy link

Superseded Unmerged By Explicit Owner Recovery Mandate

Owner's direct 2026-10-27T15:34:28Z decision authorizes a distinct, materially revised persistence-boundary recovery for #56, identity kernel56-atomic-approval-recovery-20261027T153428Z; issue receipt: #56 (comment).

This PR's delivery remains STOP_REVISE, permanently 10/10 consumed, including original PR94 specification ordinal1 and functional PR108 ordinals2-10. Preserve all original native review results, nine normal commits and branch issue-56-work-budget-enforcement at d1d55d406923674c847b98a30756a05e87b52d2c. It will be closed UNMERGED AS SUPERSEDED, never merged or given review11. This does not mark #56 complete.

Replacement branch issue-56-atomic-approval-recovery retains this full ancestry and will add a genuine atomic approval/budget-persistence correction with comprehensive rollback/recovery tests. Replacement PR will receive its separately authorized maximum four fresh complete independent reviews, not a reset or extension of this counter. Replacement link will be appended after actual creation. No original history or branch will be deleted or rewritten.

## Superseded Unmerged By Explicit Owner Recovery Mandate Owner's direct 2026-10-27T15:34:28Z decision authorizes a distinct, materially revised persistence-boundary recovery for #56, identity `kernel56-atomic-approval-recovery-20261027T153428Z`; issue receipt: https://forgejo.creatidy.com/Creatidy/creatidy-kernel/issues/56#issuecomment-19377. This PR's delivery remains **STOP_REVISE, permanently 10/10 consumed**, including original PR94 specification ordinal1 and functional PR108 ordinals2-10. Preserve all original native review results, nine normal commits and branch `issue-56-work-budget-enforcement` at `d1d55d406923674c847b98a30756a05e87b52d2c`. It will be closed **UNMERGED AS SUPERSEDED**, never merged or given review11. This does not mark #56 complete. Replacement branch `issue-56-atomic-approval-recovery` retains this full ancestry and will add a genuine atomic approval/budget-persistence correction with comprehensive rollback/recovery tests. Replacement PR will receive its separately authorized maximum four fresh complete independent reviews, not a reset or extension of this counter. Replacement link will be appended after actual creation. No original history or branch will be deleted or rewritten.
kilo closed this pull request 2026-10-27 15:38:46 +00:00
kilo commented 2026-10-27 16:22:37 +00:00
Author
Member
Copy link

Replacement PR created: #109 #109, branch issue-56-atomic-approval-recovery, HEAD 76083c7a95abd8b3e801506a1e4f55b164328bab, base e2348656238a2ff9a3244868e2beb543d86f15a5. It retains original d1d55d4 ancestry and all nine commits, and adds the substantive shared SQLite atomic acceptance boundary plus24regressions. Full primary makecheck1694PASS/85existingopt-in skips/106subtests and packagecheckPASS. New recovery0/4 before first fresh independent dispatch; this PR stays CLOSED/UNMERGED/STOP_REVISE, original10/10 unchanged.

Replacement PR created: **#109** https://forgejo.creatidy.com/Creatidy/creatidy-kernel/pulls/109, branch `issue-56-atomic-approval-recovery`, HEAD `76083c7a95abd8b3e801506a1e4f55b164328bab`, base `e2348656238a2ff9a3244868e2beb543d86f15a5`. It retains original d1d55d4 ancestry and all nine commits, and adds the substantive shared SQLite atomic acceptance boundary plus24regressions. Full primary makecheck1694PASS/85existingopt-in skips/106subtests and packagecheckPASS. New recovery0/4 before first fresh independent dispatch; this PR stays CLOSED/UNMERGED/STOP_REVISE, original10/10 unchanged.
All checks were successful
ci / check (pull_request) Successful in 3m56s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Creatidy/creatidy-kernel!108
No description provided.