Project internal resource state (#183) #244
No reviewers
Labels
No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Creatidy/scarcity-router!244
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-183-resource-state"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Scope
Partial internal producer slice for Refs #183. Adds a serialized control-plane snapshot of configured/disabled and source-derived resources, retained model discoveries and lifecycle, worker connectivity and observed freshness. Revalidates worker ownership, invalidates obsolete observations on resource/backend and derived-registration changes, and fences in-flight readiness probes. Includes deterministic regression tests. No new endpoint, consumer identity, permission, event cursor or replay contract.
Availability remains conservative and retained discovery is not evidence of connection or fresh inventory. Worker inventories and resource reports can still be applied separately. Restart loses in-memory observations/discovery. Durable events, reconnect/resync and external consumer acceptance remain open; the issue remains open.
Base:
a1c9e78c335e1b6286e17c1455a3665fc83889eeHead:
4ca972e2d28fdb9c36598727f63f8512948cd83fValidation:
uv sync --only-dev; focused producer/control/source tests;make check(3213 tests, 18 skipped, package install checks and type checking);uv run basedpyright;git diff --check. Synthetic/offline tests; no live providers.Ordinary independent whole-PR review #1 reserved (default maximum 10), imminent native user-visible read-only Kilo reviewer. Frozen HEAD
dcea94f037736e5ae62e27716deae32ebb1f990c, base/merge-basea1c9e78c335e1b6286e17c1455a3665fc83889ee. Scope is this internal producer slice; durable events and consumer authorization/acceptance remain open. This reservation is not a review result.Review #1 dispatched through native Agent Manager local session
ses_e68087303ffe0g0oGUfyM1HMpZ,pr-reviewerrole; frozen HEAD/base remain as reserved. Result pending. Dispatch metadata is not runtime identity verification or approval.Independent review #1, native session
ses_e68087303ffe0g0oGUfyM1HMpZ, at HEADdcea94f037736e5ae62e27716deae32ebb1f990c/ basea1c9e78c335e1b6286e17c1455a3665fc83889ee: REQUEST_CHANGES. Findings: current worker ownership is not revalidated inside the state lock before applying a report; absent-but-retained and retired discoveries are omitted. UX: future consumers could misinterpret worker health/quota or lifecycle. Reviewer inspected the complete canonical diff but could not verify local frozen Git objects because its Git command was denied; exact native backend identity was not independently established. Remediation and a fresh review are required; this is not approval.Review #1 findings remediated in
b310fefd5fd87ef3b2954724bc365c3932c8a90d: current source/resource ownership is rechecked under the state lock, invalidated configured observations are discarded, and retained-missing/retired discoveries are represented with no fabricated event time. Focused tests and fullmake checkpassed (3211 tests, 18 skips, package checks, basedpyright). New whole-PR review #2 reserved (maximum 10) at HEADb310fefd5fd87ef3b2954724bc365c3932c8a90d, base/merge-basea1c9e78c335e1b6286e17c1455a3665fc83889ee. Review #1's chained Git command was denied by the agent's deliberate read-only policy; retry with separate allowlisted Git commands. Reservation is not approval.Review #2 dispatched via native Agent Manager local session
ses_e67f3d3e6ffeQbIMFWum38G449,pr-reviewerrole, at reserved HEAD/base. Result pending; dispatch metadata is not an approval or independently verified backend identity.Independent review #2, native session
ses_e67f3d3e6ffeQbIMFWum38G449, at HEADb310fefd5fd87ef3b2954724bc365c3932c8a90d/ basea1c9e78c335e1b6286e17c1455a3665fc83889ee: REQUEST_CHANGES. P2: endpoint reassignment does not invalidate prior observations or fence an in-flight probe, risking old-backend health/quota being applied to the new backend. UX: future state consumers and admission can see misleading facts. Reviewer verified actual local Git merge-base and complete per-file frozen diff; no material limitations reported. Remediation and fresh review required. Native backend identity was not independently established.Review #2 finding remediated in
ce2285a46fac3eb00645cbf07552cf87c4e3a743: endpoint/binding edits invalidate observations, and both readiness-probe paths capture and check a generation under the publication lock, including endpoint ABA. Focused tests and fullmake checkpassed (3213 tests, 18 skips, package checks, basedpyright). Fresh whole-PR review #3 reserved (maximum 10) at HEADce2285a46fac3eb00645cbf07552cf87c4e3a743, base/merge-basea1c9e78c335e1b6286e17c1455a3665fc83889ee. Reservation is not approval.Review #3 dispatched via native Agent Manager local session
ses_e67e02f83ffetxcKXSrLH4xtzZ,pr-reviewerrole, at reserved HEAD/base. Result pending; dispatch metadata is not approval or independently verified backend identity.Independent review #3, native session
ses_e67e02f83ffetxcKXSrLH4xtzZ, at HEADce2285a46fac3eb00645cbf07552cf87c4e3a743/ basea1c9e78c335e1b6286e17c1455a3665fc83889ee: REQUEST_CHANGES. P2: retired derived resources retain old observations and can reapply them as fresh after rediscovery. The reviewer verified Git merge-base and complete frozen diff; no material source limitations reported. UX: a future consumer and routing could see pre-retirement health/quota as current. Remediation and fresh review required; native backend identity not independently established.Review #3 finding remediated in
4ca972e2d28fdb9c36598727f63f8512948cd83f: source-derived observations are discarded when their registration disappears, with a deterministic observed-retirement-rediscovery test inside the original TTL. Focused tests and fullmake checkpassed (3213 tests, 18 skipped, package checks and basedpyright). Fresh whole-PR review #4 reserved (maximum 10) at HEAD4ca972e2d28fdb9c36598727f63f8512948cd83f, base/merge-basea1c9e78c335e1b6286e17c1455a3665fc83889ee. Reservation is not approval.Review #4 dispatched via native Agent Manager local session
ses_e67ccc01cffePuvRa0VaHb9zsP,pr-reviewerrole, at reserved HEAD/base. Result pending; dispatch metadata is not approval or independently verified backend identity.Independent review #4, native session
ses_e67ccc01cffePuvRa0VaHb9zsP, returned APPROVE with empty findings at HEAD4ca972e2d28fdb9c36598727f63f8512948cd83f/ base and merge-basea1c9e78c335e1b6286e17c1455a3665fc83889ee. Reviewer verified Git merge-base and complete frozen diff. UX: no external interface; projection distinguishes disabled/disconnected/stale/unknown. Reviewer did not independently verify native session's underlying permission configuration; observed operations were read-only Git/Forgejo getters. Runtime model identity is not established by dispatch metadata. Assessing remaining native provenance and CI gates; no merge claimed.Native provenance recovery for review #4: read-only, session-scoped Kilo database metadata identifies session agent
pr-reviewer; assistant message metadata records provideropenai, modelgpt-6.1-terra. The reviewer used read-only Git and Forgejo getters. Session metadata has no per-session permission override; the selected workspace reviewer profile is read-only. This is native model/agent metadata, not independent proof of a remote backend identity. No credentials or unrelated session content were inspected.Pre-merge revalidation: independently reviewed HEAD
4ca972e2d28fdb9c36598727f63f8512948cd83f, freshly fetched base/merge-basea1c9e78c335e1b6286e17c1455a3665fc83889ee, clean delivery checkout, no excluded issue labels. Forgejo workflow run #3439 completed SUCCESS at this HEAD; the newestci / check (pull_request)status is success, though the combined status resource still reports pending and includes two earlier pending records for the same run/context. Branch-protection inspection was denied to the available token. No force, auto-merge or policy bypass will be used; any protection rejection remains a gate.