Creatidy/scarcity-router
5
0
Fork 0
Code Issues 13 Pull requests Projects Releases Packages Wiki Activity Actions

Bind worker credentials to paired origin (#224) #236

Merged
kilo merged 2 commits from issue-224-origin-bound-worker into develop 2026-10-30 09:31:33 +00:00
Conversation 6 Commits 2 Files changed 4 +48 -7
kilo commented 2026-10-30 08:23:54 +00:00
Member
Copy link

Scope

Refs #224. Refuse worker runtime connections to an origin different from the stored paired origin before sending the worker credential. Host, port and scheme changes fail closed; paired-origin operation and origin-bound private CA trust remain intact. This is containment only, not verified origin migration. Tier B, certificate lifecycle and migration remain open.

CI remediation: isolate package-lifecycle unit tests from checkout dist/ and ambient baseline overrides using a temporary synthetic wheel. Production package behavior remains unchanged.

Validation

  • Focused worker, CA trust and real-TLS suites: 143 passed. Focused package-lifecycle tests: 10 passed with a synthetic nonexistent ambient baseline override.
  • uv sync --only-dev; fixed-seed PYTHONHASHSEED=0 make check: 3,181 passed, 18 skipped, basedpyright 0/0; standalone uv run basedpyright, make package-check, and whitespace checks passed.
  • An earlier unseeded gate failed in an intermittent Codex fake-feeder thread stderr assertion; exact errno unverified, details retained in comments. The prior standalone suite passed; no test was skipped or suppressed.
  • Synthetic/offline evidence only. Live Windows and deployed network acceptance not claimed.

Review

Review #7 approved the preceding HEAD but is invalidated by the fixture change. Fresh complete security-critical GPT-6.1 Sol High review and current-HEAD CI are pending; all historical #224 review ordinals remain preserved.

## Scope Refs #224. Refuse worker runtime connections to an origin different from the stored paired origin before sending the worker credential. Host, port and scheme changes fail closed; paired-origin operation and origin-bound private CA trust remain intact. This is containment only, not verified origin migration. Tier B, certificate lifecycle and migration remain open. CI remediation: isolate package-lifecycle unit tests from checkout `dist/` and ambient baseline overrides using a temporary synthetic wheel. Production package behavior remains unchanged. ## Validation - Focused worker, CA trust and real-TLS suites: 143 passed. Focused package-lifecycle tests: 10 passed with a synthetic nonexistent ambient baseline override. - `uv sync --only-dev`; fixed-seed `PYTHONHASHSEED=0 make check`: 3,181 passed, 18 skipped, basedpyright 0/0; standalone `uv run basedpyright`, `make package-check`, and whitespace checks passed. - An earlier unseeded gate failed in an intermittent Codex fake-feeder thread stderr assertion; exact errno unverified, details retained in comments. The prior standalone suite passed; no test was skipped or suppressed. - Synthetic/offline evidence only. Live Windows and deployed network acceptance not claimed. ## Review Review #7 approved the preceding HEAD but is invalidated by the fixture change. Fresh complete security-critical GPT-6.1 Sol High review and current-HEAD CI are pending; all historical #224 review ordinals remain preserved.
Bind worker credentials to paired origin (#224)
Some checks failed
ci / check (pull_request) Failing after 10m54s
Details
ce7be1b124
kilo commented 2026-10-30 08:24:01 +00:00
Author
Member
Copy link

Reserving imminent independent whole-PR security/correctness/UX review #7/10 for issue #224 (six previous invocations retained under PR #233). Frozen HEAD ce7be1b1241c24f4a785d6c7e8a928231a091b8e, base and merge-base f141a6998fb0b9588d4908bc22c286586d1efc1a. Requested native pr-reviewer, GPT-6.1 Sol/openai/high as explicitly owner-directed. Scope is origin-mismatch containment only, not origin migration. Required CI pending; no approval is implied by this reservation.

Reserving imminent independent whole-PR security/correctness/UX review #7/10 for issue #224 (six previous invocations retained under PR #233). Frozen HEAD `ce7be1b1241c24f4a785d6c7e8a928231a091b8e`, base and merge-base `f141a6998fb0b9588d4908bc22c286586d1efc1a`. Requested native `pr-reviewer`, GPT-6.1 Sol/openai/high as explicitly owner-directed. Scope is origin-mismatch containment only, not origin migration. Required CI pending; no approval is implied by this reservation.
kilo commented 2026-10-30 08:27:58 +00:00
Author
Member
Copy link

Independent whole-PR review #7/10: APPROVE, findings [], limitations [], exact HEAD ce7be1b1241c24f4a785d6c7e8a928231a091b8e, base/merge-base f141a6998fb0b9588d4908bc22c286586d1efc1a. Fresh native pr-reviewer session ses_e74174032ffeunZ7bEpmZkBCh4, dispatched GPT-6.1 Sol/openai/high; backend runtime identity independently unobserved. Reviewer inspected complete frozen diff and worker connection, credential, trust, TLS, service and UX context, verified clean frozen refs and diff whitespace; did not run test suites. UX: different-origin override fails before connection with actionable diagnostic; same-origin services unchanged. CI remains required, and origin migration/tier B/certificate lifecycle are not claimed.

Independent whole-PR review #7/10: **APPROVE**, findings `[]`, limitations `[]`, exact HEAD `ce7be1b1241c24f4a785d6c7e8a928231a091b8e`, base/merge-base `f141a6998fb0b9588d4908bc22c286586d1efc1a`. Fresh native `pr-reviewer` session `ses_e74174032ffeunZ7bEpmZkBCh4`, dispatched GPT-6.1 Sol/openai/high; backend runtime identity independently unobserved. Reviewer inspected complete frozen diff and worker connection, credential, trust, TLS, service and UX context, verified clean frozen refs and diff whitespace; did not run test suites. UX: different-origin override fails before connection with actionable diagnostic; same-origin services unchanged. CI remains required, and origin migration/tier B/certificate lifecycle are not claimed.
kilo commented 2026-10-30 08:36:22 +00:00
Author
Member
Copy link

CI run #3376 failed at repository tests: 5 failures and 1 error in test_package_lifecycle, all because the fake lifecycle unexpectedly reads a baseline wheel from checkout dist/, absent on the clean runner. Earlier local validation had a pre-existing built wheel, so did not reproduce a clean checkout. Forgejo v15 Actions jobs/artifacts MCP endpoints returned 404; the public run UI exposed the failure log. Scoped test-fixture remediation is underway, supplying a synthetic temporary wheel rather than depending on checkout artifacts. This changes HEAD and invalidates review #7; a fresh complete review will be required under the same #224 counter.

CI run #3376 failed at repository tests: 5 failures and 1 error in `test_package_lifecycle`, all because the fake lifecycle unexpectedly reads a baseline wheel from checkout `dist/`, absent on the clean runner. Earlier local validation had a pre-existing built wheel, so did not reproduce a clean checkout. Forgejo v15 Actions jobs/artifacts MCP endpoints returned 404; the public run UI exposed the failure log. Scoped test-fixture remediation is underway, supplying a synthetic temporary wheel rather than depending on checkout artifacts. This changes HEAD and invalidates review #7; a fresh complete review will be required under the same #224 counter.
kilo commented 2026-10-30 09:03:48 +00:00
Author
Member
Copy link

Final make check after package-fixture remediation ran 3,181 tests and failed once in test_openai_codex_acquisition.MalformedAndBoundedOutput.test_oversized_line_with_secret_never_leaks: captured stderr contained an exception from _FakeAppServer._feed after a closed pipe. The assertion truncates the underlying traceback, so the exact errno remains unverified. This resembles the historical excluded #166 feeder/close race, but is not proven identical and is not attributed to this PR. The immediately preceding full standalone suite passed 3,181 tests. A changed-condition fixed-hash-seed gate will be attempted without suppressing or skipping the test; this failure remains recorded.

Final `make check` after package-fixture remediation ran 3,181 tests and failed once in `test_openai_codex_acquisition.MalformedAndBoundedOutput.test_oversized_line_with_secret_never_leaks`: captured stderr contained an exception from `_FakeAppServer._feed` after a closed pipe. The assertion truncates the underlying traceback, so the exact errno remains unverified. This resembles the historical excluded #166 feeder/close race, but is not proven identical and is not attributed to this PR. The immediately preceding full standalone suite passed 3,181 tests. A changed-condition fixed-hash-seed gate will be attempted without suppressing or skipping the test; this failure remains recorded.
Isolate package lifecycle test wheel (#224)
All checks were successful
ci / check (pull_request) Successful in 11m32s
Details
4b903874da
kilo commented 2026-10-30 09:18:19 +00:00
Author
Member
Copy link

Reserving imminent fresh independent whole-PR review #8/10 for issue #224. Frozen HEAD 4b903874da53dc6ba06740b70d5aedb55054f252, base/merge-base f141a6998fb0b9588d4908bc22c286586d1efc1a. Review #7 APPROVE was invalidated by the CI-fixture commit; prior ordinals remain consumed. Scope includes credential-origin containment and the necessary clean-runner fixture repair, not verified migration. Requested native pr-reviewer, GPT-6.1 Sol/openai/high. Fixed-seed full gate passed; current-head CI #3379 running.

Reserving imminent fresh independent whole-PR review #8/10 for issue #224. Frozen HEAD `4b903874da53dc6ba06740b70d5aedb55054f252`, base/merge-base `f141a6998fb0b9588d4908bc22c286586d1efc1a`. Review #7 APPROVE was invalidated by the CI-fixture commit; prior ordinals remain consumed. Scope includes credential-origin containment and the necessary clean-runner fixture repair, not verified migration. Requested native `pr-reviewer`, GPT-6.1 Sol/openai/high. Fixed-seed full gate passed; current-head CI #3379 running.
kilo commented 2026-10-30 09:24:57 +00:00
Author
Member
Copy link

Independent whole-PR review #8/10: APPROVE, findings [], limitations [], exact HEAD 4b903874da53dc6ba06740b70d5aedb55054f252, base/merge-base f141a6998fb0b9588d4908bc22c286586d1efc1a. Fresh native pr-reviewer session ses_e73e588c7ffeMVlkB9BVh3wQzy, dispatched GPT-6.1 Sol/openai/high; backend runtime identity independently unobserved. Complete frozen diff, credential-origin/TLS/CA/service paths, test fixture isolation and UX assessed; reviewer did not run suites. UX: mismatch gives actionable credential-free failure and paired-origin behavior is retained. Current-head CI #3379 still running; no migration, tier B or lifecycle completion claimed.

Independent whole-PR review #8/10: **APPROVE**, findings `[]`, limitations `[]`, exact HEAD `4b903874da53dc6ba06740b70d5aedb55054f252`, base/merge-base `f141a6998fb0b9588d4908bc22c286586d1efc1a`. Fresh native `pr-reviewer` session `ses_e73e588c7ffeMVlkB9BVh3wQzy`, dispatched GPT-6.1 Sol/openai/high; backend runtime identity independently unobserved. Complete frozen diff, credential-origin/TLS/CA/service paths, test fixture isolation and UX assessed; reviewer did not run suites. UX: mismatch gives actionable credential-free failure and paired-origin behavior is retained. Current-head CI #3379 still running; no migration, tier B or lifecycle completion claimed.
kilo merged commit 98ae0e4e6c into develop 2026-10-30 09:31:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
P1
Owner-declared highest explicit implementation priority (loop ordering rank)

  
P2
Required product and integration work

  
P3
Deferred or producer-dependent work

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Creatidy/scarcity-router!236
No description provided.