[P1][workflow] Allow private Forgejo MCP reads in independent PR review #37

New issue

Closed

opened 2026-10-11 15:37:50 +00:00 by kilo · 2 comments

kilo commented

2026-10-11 15:37:50 +00:00

Member

Problem

.kilo/agents/pr-reviewer.md requires anonymous canonical git ls-remote, which blocks reviews when Git transport is private or unavailable to the reviewer.

Authorized behavior and scope

Use read-only Forgejo MCP to verify canonical repository identity, current open PR metadata, head/base refs and exact commit identities. Independently verify the primary-prepared clean local checkout, exact SHA objects, merge base and complete whole-PR diff. Anonymous git ls-remote may add evidence when available but is not required. Reviewer credentials stay unavailable to model/shell; MCP must not disclose tokens. Keep implementation fetch/branch/commit/push on normal Git, and prohibit reviewer MCP writes/mutations. Preserve fresh independent context, frozen HEAD/base, review ordinals, provider/model policy and all required validation/CI/merge gates.

Affected: .kilo/agents/pr-reviewer.md, applicable command/rule references and workflow tests only as needed.

Acceptance

A no-anonymous-Git fixture can be reviewed when canonical MCP and exact prepared local evidence match; missing or mismatched identity/ref/SHA must refuse approval. Existing security and whole-PR requirements remain unchanged.

Non-goals

No implementation/integration, reviewer credentials, MCP writes, or weakened gates.

## Problem `.kilo/agents/pr-reviewer.md` requires anonymous canonical `git ls-remote`, which blocks reviews when Git transport is private or unavailable to the reviewer. ## Authorized behavior and scope Use read-only Forgejo MCP to verify canonical repository identity, current open PR metadata, head/base refs and exact commit identities. Independently verify the primary-prepared clean local checkout, exact SHA objects, merge base and complete whole-PR diff. Anonymous `git ls-remote` may add evidence when available but is not required. Reviewer credentials stay unavailable to model/shell; MCP must not disclose tokens. Keep implementation fetch/branch/commit/push on normal Git, and prohibit reviewer MCP writes/mutations. Preserve fresh independent context, frozen HEAD/base, review ordinals, provider/model policy and all required validation/CI/merge gates. Affected: `.kilo/agents/pr-reviewer.md`, applicable command/rule references and workflow tests only as needed. ## Acceptance A no-anonymous-Git fixture can be reviewed when canonical MCP and exact prepared local evidence match; missing or mismatched identity/ref/SHA must refuse approval. Existing security and whole-PR requirements remain unchanged. ## Non-goals No implementation/integration, reviewer credentials, MCP writes, or weakened gates.

kilo referenced this issue

2026-10-11 15:45:46 +00:00

Allow MCP reads for independent PR reviews #38

kilo commented

2026-10-11 15:45:53 +00:00

Author

Member

Implemented the #37 workflow change in PR #38: #38 (Refs #37). Read-only Forgejo MCP now verifies canonical repository identity and current PR refs/SHAs; anonymous git ls-remote is optional, while exact local objects, clean HEAD, merge base, and full diff remain required. make check passed in a sanitized offline environment (172 tests, Ruff, format, basedpyright, locked sync, whitespace). Base 938f4160493359f9795c3bda081b065afac96b16; head 63a70ead48d1992feccece9487b365bd333ae576. PR remains open and unmerged.

Implemented the #37 workflow change in PR #38: https://forgejo.creatidy.com/Creatidy/model-intelligence/pulls/38 (`Refs #37`). Read-only Forgejo MCP now verifies canonical repository identity and current PR refs/SHAs; anonymous `git ls-remote` is optional, while exact local objects, clean HEAD, merge base, and full diff remain required. `make check` passed in a sanitized offline environment (172 tests, Ruff, format, basedpyright, locked sync, whitespace). Base `938f4160493359f9795c3bda081b065afac96b16`; head `63a70ead48d1992feccece9487b365bd333ae576`. PR remains open and unmerged.

kilo commented

2026-10-11 15:52:08 +00:00

Author

Member

PR #38 completed the requested review workflow: fresh independent whole-PR review ordinal 4 APPROVED with no findings at head 9fc675d2dec301add11b941fe7212f6e202e6f47 / base 938f4160493359f9795c3bda081b065afac96b16. Ordinals 1-3 were COMMENT infrastructure attempts only; no code findings. Final MCP/Git currentness matched and the checkout is clean. Sanitized offline make check passed (172 tests, lint, format, typing, locked sync, whitespace). PR remains open/unmerged and issue #37 remains open.

PR #38 completed the requested review workflow: fresh independent whole-PR review ordinal 4 APPROVED with no findings at head `9fc675d2dec301add11b941fe7212f6e202e6f47` / base `938f4160493359f9795c3bda081b065afac96b16`. Ordinals 1-3 were COMMENT infrastructure attempts only; no code findings. Final MCP/Git currentness matched and the checkout is clean. Sanitized offline `make check` passed (172 tests, lint, format, typing, locked sync, whitespace). PR remains open/unmerged and issue #37 remains open.