Creatidy/foundry
5
0
Fork 0
Code Issues 2 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Correct bootstrap publication and integration status #2

Merged
kilo merged 2 commits from issue/1-sr-mi-integration into main 2026-10-31 21:52:27 +00:00
Conversation 2 Commits 2 Files changed 3 +9 -6
kilo commented 2026-10-31 20:37:44 +00:00
Member
Copy link

Scope

Correct the published Foundry repository status, document the inspected SR image TLS flag prerequisite and accurately state the current SR–MI server integration limitation. This is a bounded documentation correction, not delivery of M1, and does not close #1.

Validation

  • git diff --check
  • docker compose --env-file .env.example -f compose.yaml config --quiet (rendering only, with placeholders)
  • Prior real-source explicit-input experiment and its limitations: #1 (comment)

Remaining blocker

SR's opt-in composed-server consumer path is tracked in Creatidy/scarcity-router#238. Authenticated installed integration, live evidence adoption and target-host acceptance remain unverified.

Fresh independent review of the exact PR head and base is required before integration; no main promotion is authorized by this PR.

## Scope Correct the published Foundry repository status, document the inspected SR image TLS flag prerequisite and accurately state the current SR–MI server integration limitation. This is a bounded documentation correction, **not** delivery of M1, and does not close #1. ## Validation - `git diff --check` - `docker compose --env-file .env.example -f compose.yaml config --quiet` (rendering only, with placeholders) - Prior real-source explicit-input experiment and its limitations: https://forgejo.creatidy.com/Creatidy/foundry/issues/1#issuecomment-20103 ## Remaining blocker SR's opt-in composed-server consumer path is tracked in https://forgejo.creatidy.com/Creatidy/scarcity-router/issues/238. Authenticated installed integration, live evidence adoption and target-host acceptance remain unverified. Fresh independent review of the exact PR head and base is required before integration; no main promotion is authorized by this PR.
kilo reviewed 2026-10-31 20:41:38 +00:00
kilo left a comment
Copy link

Automated independent review — COMMENT only. Posted by a Kilo agent running model GLM-5.3. This is not a human review, not an approval, and no merge action was taken or requested.

Revisions confirmed: head 067a7fc82b8f4135d21c67a4f08d4f7bbaa09845 vs base f9445571739700d17d30f5167d4e264da622ea52 (base = main and = merge base). Diff is docs-only: .env.example, README.md, docs/milestones.md (+9/−6).

Upstream claims verified against canonical Forgejo at the cited revisions:

  • Creatidy/scarcity-router @ 209f7d39f3ecebbd1b98b11d7c44c63192fe50a4: scarcity_router/control_server.py defines --tls-reload-hostname (and --worker-tls-reload-hostname); first parent 98ae0e4e6cbeac66d098c194aa914fafb57a1460 (prior develop tip) does not. Dockerfile installs the wheel only, without the [mi] extra. pyproject.toml optional pin is model-intelligence@d65891668b7e79f7b666c021f02a1b4bf8c4ca9c. Zero releases published (claim "No SR release is published" holds).
  • Creatidy/model-intelligence: develop HEAD is currently e8a6b81546994438038d22fd08fc041c6901d9cd as stated; the pinned d65891668b7e79f7b666c021f02a1b4bf8c4ca9c exists and differs, as stated.
  • The composed control server at that revision has no MI consumer configuration (parser and imports confirmed) — README's integration-limitation statement is accurate.
  • Publishing status: Creatidy/foundry exists on canonical Forgejo with the bootstrap on main (the base commit). Accurate.
  • Validation reproduced locally by this review: git diff --check clean; docker compose --env-file .env.example -f compose.yaml config --quiet exits 0.
  • compose.yaml:16 does pass --tls-reload-hostname, so the new .env.example note is consistent with the Compose.

Findings:

  1. LOW (docs precision) — README.md M0 step 1: "while its parent does not" is ambiguous. 209f7d39… is a merge commit with two parents; the second parent 89f39161e42d6a788edf3a3d6d85ba880005777a (final feature commit of SR PR #237) does support the flag. The statement is true only for the first parent 98ae0e4e… (prior develop tip). Suggest "its first parent (the prior develop tip)".
  2. LOW (guardrail note) — README.md repositories table drops the "owner-reported migration; verify canonical URL before integration" hedge. The assertion is accurate as of this review (existence, history, commits re-verified), but docs/repository-migration.md still requires independent verification before the first SR-touching PR; that internal gate should stay in force even though the public table no longer carries the hedge.
  3. LOW (staleness) — README.md: "at the time of this inspection" claims (no SR release; MI develop HEAD) carry no inspection date. Accurate today, but will silently go stale; add the inspection date so readers can judge freshness.
  4. LOW (missing enforcement) — repository has no CI workflows and no tests; the PR's claimed validations (git diff --check, Compose render) are not enforced anywhere. Non-blocking for a docs-only change, but a minimal Forgejo Actions workflow running docker compose --env-file .env.example -f compose.yaml config --quiet would keep compose.yaml and .env.example honest as they evolve.

Security: no regression — no secrets, no TLS weakening, no exposure changes; compose.yaml unchanged. The public-CA trust statement matches SR's Dockerfile healthcheck semantics with SR_HEALTHCHECK_CA unset.

Unsupported integration claims: none found. The diff explicitly disclaims installation acceptance, an accepted/tested bill of materials, and production readiness; M0/M1 gates in docs/milestones.md remain unchecked, consistent with the PR description ("not delivery of M1").

Conclusion: no blocking findings (4 LOW). Merge decision remains exclusively with the human owner.

**Automated independent review — COMMENT only.** Posted by a Kilo agent running model **GLM-5.3**. This is not a human review, not an approval, and no merge action was taken or requested. **Revisions confirmed:** head `067a7fc82b8f4135d21c67a4f08d4f7bbaa09845` vs base `f9445571739700d17d30f5167d4e264da622ea52` (base = `main` and = merge base). Diff is docs-only: `.env.example`, `README.md`, `docs/milestones.md` (+9/−6). **Upstream claims verified against canonical Forgejo at the cited revisions:** - `Creatidy/scarcity-router` @ `209f7d39f3ecebbd1b98b11d7c44c63192fe50a4`: `scarcity_router/control_server.py` defines `--tls-reload-hostname` (and `--worker-tls-reload-hostname`); first parent `98ae0e4e6cbeac66d098c194aa914fafb57a1460` (prior `develop` tip) does not. `Dockerfile` installs the wheel only, without the `[mi]` extra. `pyproject.toml` optional pin is `model-intelligence@d65891668b7e79f7b666c021f02a1b4bf8c4ca9c`. Zero releases published (claim "No SR release is published" holds). - `Creatidy/model-intelligence`: `develop` HEAD is currently `e8a6b81546994438038d22fd08fc041c6901d9cd` as stated; the pinned `d65891668b7e79f7b666c021f02a1b4bf8c4ca9c` exists and differs, as stated. - The composed control server at that revision has **no MI consumer configuration** (parser and imports confirmed) — README's integration-limitation statement is accurate. - Publishing status: `Creatidy/foundry` exists on canonical Forgejo with the bootstrap on `main` (the base commit). Accurate. - Validation reproduced locally by this review: `git diff --check` clean; `docker compose --env-file .env.example -f compose.yaml config --quiet` exits 0. - `compose.yaml:16` does pass `--tls-reload-hostname`, so the new `.env.example` note is consistent with the Compose. **Findings:** 1. **LOW (docs precision)** — `README.md` M0 step 1: "while its parent does not" is ambiguous. `209f7d39…` is a **merge commit** with two parents; the second parent `89f39161e42d6a788edf3a3d6d85ba880005777a` (final feature commit of SR PR #237) *does* support the flag. The statement is true only for the first parent `98ae0e4e…` (prior `develop` tip). Suggest "its first parent (the prior `develop` tip)". 2. **LOW (guardrail note)** — `README.md` repositories table drops the "owner-reported migration; verify canonical URL before integration" hedge. The assertion is accurate as of this review (existence, history, commits re-verified), but `docs/repository-migration.md` still requires independent verification before the first SR-touching PR; that internal gate should stay in force even though the public table no longer carries the hedge. 3. **LOW (staleness)** — `README.md`: "at the time of this inspection" claims (no SR release; MI `develop` HEAD) carry no inspection date. Accurate today, but will silently go stale; add the inspection date so readers can judge freshness. 4. **LOW (missing enforcement)** — repository has no CI workflows and no tests; the PR's claimed validations (`git diff --check`, Compose render) are not enforced anywhere. Non-blocking for a docs-only change, but a minimal Forgejo Actions workflow running `docker compose --env-file .env.example -f compose.yaml config --quiet` would keep `compose.yaml` and `.env.example` honest as they evolve. **Security:** no regression — no secrets, no TLS weakening, no exposure changes; `compose.yaml` unchanged. The public-CA trust statement matches SR's Dockerfile healthcheck semantics with `SR_HEALTHCHECK_CA` unset. **Unsupported integration claims:** none found. The diff explicitly disclaims installation acceptance, an accepted/tested bill of materials, and production readiness; M0/M1 gates in `docs/milestones.md` remain unchecked, consistent with the PR description ("not delivery of M1"). **Conclusion:** no blocking findings (4 LOW). Merge decision remains exclusively with the human owner.
kilo reviewed 2026-10-31 21:52:04 +00:00
kilo left a comment
Copy link

Automated follow-up verification — COMMENT only. Posted by a Kilo agent running model GLM-5.3. Not a human review, not an approval; no merge action taken or requested.

Final head verified: 423bf2412e9eed8416558f7e791c8663a9066737 (one commit on top of previously reviewed 067a7fc82b8f4135d21c67a4f08d4f7bbaa09845), base still f9445571739700d17d30f5167d4e264da622ea52 (= main = merge base).

Incremental delta: README.md only (2 line-pairs). Blob hashes confirm compose.yaml, .env.example and docs/milestones.md are byte-identical to the prior head, so the earlier docker compose --env-file .env.example -f compose.yaml config --quiet exit-0 render applies unchanged to this head; git diff --check over the full range is clean; aggregate diff vs base is unchanged (+9/−6, same 3 files).

Two corrections verified:

  1. "while its parent does not" → "while its first parent (the prior develop tip) does not" — resolves the merge-commit ambiguity I reported. Verified earlier against canonical Forgejo: 209f7d39… defines --tls-reload-hostname in scarcity_router/control_server.py; first parent 98ae0e4e6cbeac66d098c194aa914fafb57a1460 (prior develop tip) does not; second parent 89f39161e42d6a788edf3a3d6d85ba880005777a does. The corrected sentence is now precise and accurate.
  2. Undated "at inspection" claims → "as of 2026-10-31" / "at the 2026-10-31 inspection" — resolves the staleness finding. Verified today: Creatidy/scarcity-router has zero releases; Creatidy/model-intelligence develop HEAD is e8a6b81546994438038d22fd08fc041c6901d9cd.

Prior review status at this final head: all previously verified external claims (SR flag support/parent absence, Dockerfile without [mi] extra, MI pin d6589166… vs HEAD divergence, no MI consumer configuration in the composed control server, Foundry publication) remain valid — the corrections alter wording only, citing the same SHAs. Of my four prior LOW findings, #1 and #3 are resolved; #2 (dropped canonical-URL hedge in the repositories table; keep the docs/repository-migration.md verification gate internally) and #4 (no CI enforcement of the claimed validations) remain open by design, advisory and non-blocking. No new issues introduced; no security or integration-claim changes.

Conclusion: no blocking findings at 423bf24…. Merge decision remains exclusively with the human owner.

**Automated follow-up verification — COMMENT only.** Posted by a Kilo agent running model **GLM-5.3**. Not a human review, not an approval; no merge action taken or requested. **Final head verified:** `423bf2412e9eed8416558f7e791c8663a9066737` (one commit on top of previously reviewed `067a7fc82b8f4135d21c67a4f08d4f7bbaa09845`), base still `f9445571739700d17d30f5167d4e264da622ea52` (= `main` = merge base). **Incremental delta:** `README.md` only (2 line-pairs). Blob hashes confirm `compose.yaml`, `.env.example` and `docs/milestones.md` are byte-identical to the prior head, so the earlier `docker compose --env-file .env.example -f compose.yaml config --quiet` exit-0 render applies unchanged to this head; `git diff --check` over the full range is clean; aggregate diff vs base is unchanged (+9/−6, same 3 files). **Two corrections verified:** 1. "while its parent does not" → "while its **first parent (the prior `develop` tip)** does not" — resolves the merge-commit ambiguity I reported. Verified earlier against canonical Forgejo: `209f7d39…` defines `--tls-reload-hostname` in `scarcity_router/control_server.py`; first parent `98ae0e4e6cbeac66d098c194aa914fafb57a1460` (prior `develop` tip) does not; second parent `89f39161e42d6a788edf3a3d6d85ba880005777a` does. The corrected sentence is now precise and accurate. 2. Undated "at inspection" claims → "**as of 2026-10-31**" / "at the **2026-10-31** inspection" — resolves the staleness finding. Verified today: `Creatidy/scarcity-router` has zero releases; `Creatidy/model-intelligence` `develop` HEAD is `e8a6b81546994438038d22fd08fc041c6901d9cd`. **Prior review status at this final head:** all previously verified external claims (SR flag support/parent absence, Dockerfile without `[mi]` extra, MI pin `d6589166…` vs HEAD divergence, no MI consumer configuration in the composed control server, Foundry publication) remain valid — the corrections alter wording only, citing the same SHAs. Of my four prior LOW findings, #1 and #3 are resolved; #2 (dropped canonical-URL hedge in the repositories table; keep the `docs/repository-migration.md` verification gate internally) and #4 (no CI enforcement of the claimed validations) remain open by design, advisory and non-blocking. No new issues introduced; no security or integration-claim changes. **Conclusion:** no blocking findings at `423bf24…`. Merge decision remains exclusively with the human owner.
kilo merged commit b76cc82ca2 into main 2026-10-31 21:52:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Creatidy/foundry!2
No description provided.