Make pr-reviewer binding provider/model-agnostic #70

Merged

kilo merged 2 commits from maintenance/pr-reviewer-binding into develop

2026-10-05 19:41:04 +00:00

kilo commented

2026-10-05 19:13:14 +00:00

Member

Owner-authorized maintenance (direct instruction, 2026-10-05): make the pr-reviewer contract provider/model-binding agnostic.

Change

Only .kilo/agents/pr-reviewer.md:

removed frontmatter model: openai/gpt-6.1-sol and variant: high (no replacement pin);
removed the prose asserting the GPT-6.1 Sol High binding and the installed Kilo 7.8.3 model listing;
inserted the canonical ## Reviewer binding policy: reviewer inherits the implementation session's provider family/model/reasoning configuration by default, with OpenAI→OpenAI and z.ai→z.ai provider-family affinity, explicit owner override support, no silent substitution, and precise reporting when a binding cannot be executed.

Preserved

Kernel-specific permission allowlists (git -C .../creatidy-kernel-*, env -i sandboxed make -C checks, external_directory scoping, web-reader_webReader), the NOTICE provenance comment, checkout/read-only constraints, secret/environment restrictions, rule references, whole-PR/exact-HEAD semantics, verdict semantics, evidence isolation, and the stable JSON result schema (no new fields).

Validation

YAML frontmatter parses; remaining keys: description, mode, permission
no openai/gpt-6.1-sol, variant: high, GPT-6.1 or Kilo 7.8.3 references remain
git diff --name-only origin/develop...HEAD → only .kilo/agents/pr-reviewer.md
local python3 -m unittest tests.test_workflow_contract: 12 tests, exactly 1 failure

⚠ Why this PR is not merged

The task's scope guard allows changing only .kilo/agents/pr-reviewer.md. But tests/test_workflow_contract.py::test_command_inventory_gates_and_reviewer_permissions (line ~275) asserts the exact removed frontmatter pin mode: subagent\nmodel: openai/gpt-6.1-sol\nvariant: high\n — the test enforces the very binding this maintenance removes. The expected single CI failure is that assertion.

Merging requires a one-line follow-up updating that assertion to the new binding-agnostic frontmatter (e.g. assert mode: subagent plus the permission block, and that no model:/variant: pin exists). That file is outside this task's authorized scope, so the owner must authorize it. Everything else in the change is complete and validated.

Owner-authorized maintenance (direct instruction, 2026-10-05): make the `pr-reviewer` contract provider/model-binding agnostic. ## Change Only `.kilo/agents/pr-reviewer.md`: - removed frontmatter `model: openai/gpt-6.1-sol` and `variant: high` (no replacement pin); - removed the prose asserting the GPT-6.1 Sol High binding and the installed Kilo 7.8.3 model listing; - inserted the canonical `## Reviewer binding` policy: reviewer inherits the implementation session's provider family/model/reasoning configuration by default, with OpenAI→OpenAI and z.ai→z.ai provider-family affinity, explicit owner override support, no silent substitution, and precise reporting when a binding cannot be executed. ## Preserved Kernel-specific permission allowlists (`git -C .../creatidy-kernel-*`, `env -i` sandboxed `make -C` checks, `external_directory` scoping, `web-reader_webReader`), the NOTICE provenance comment, checkout/read-only constraints, secret/environment restrictions, rule references, whole-PR/exact-HEAD semantics, verdict semantics, evidence isolation, and the stable JSON result schema (no new fields). ## Validation - YAML frontmatter parses; remaining keys: `description`, `mode`, `permission` - no `openai/gpt-6.1-sol`, `variant: high`, `GPT-6.1` or `Kilo 7.8.3` references remain - `git diff --name-only origin/develop...HEAD` → only `.kilo/agents/pr-reviewer.md` - local `python3 -m unittest tests.test_workflow_contract`: 12 tests, exactly 1 failure ## ⚠ Why this PR is not merged The task's scope guard allows changing only `.kilo/agents/pr-reviewer.md`. But `tests/test_workflow_contract.py::test_command_inventory_gates_and_reviewer_permissions` (line ~275) asserts the exact removed frontmatter pin `mode: subagent\nmodel: openai/gpt-6.1-sol\nvariant: high\n` — the test enforces the very binding this maintenance removes. The expected single CI failure is that assertion. Merging requires a one-line follow-up updating that assertion to the new binding-agnostic frontmatter (e.g. assert `mode: subagent` plus the permission block, and that no `model:`/`variant:` pin exists). That file is outside this task's authorized scope, so the owner must authorize it. Everything else in the change is complete and validated.

kilo added 1 commit

2026-10-05 19:13:14 +00:00

docs(workflow): make pr-reviewer binding provider/model-agnostic

ci / check (pull_request) Failing after 1m3s

Details

e4941469a1

Remove the hard-coded openai/gpt-6.1-sol + variant: high reviewer pin and the
Kilo 7.8.3 runtime-version assertion from the pr-reviewer contract. The
reviewer now inherits the implementation session's provider family, model and
reasoning/thinking configuration, with OpenAI-to-OpenAI and z.ai-to-z.ai
affinity by default, overridable only by explicit owner instruction.
Repository-specific permissions, validation allowlists, env -i sandboxed
checks, read-only behavior and the stable JSON result schema are unchanged.

Owner-authorized maintenance; changes only .kilo/agents/pr-reviewer.md.

Known gate interaction: tests/test_workflow_contract.py still asserts the
removed frontmatter pin (line ~275), which this maintenance is explicitly not
allowed to modify; see PR description.

adrian.tkacz referenced this pull request from a commit

2026-10-05 19:39:19 +00:00

test(workflow): enforce binding-agnostic reviewer contract

adrian.tkacz added 1 commit

2026-10-05 19:39:19 +00:00

test(workflow): enforce binding-agnostic reviewer contract

ci / check (pull_request) Successful in 1m10s

Details

763c543051

Replace the literal frontmatter pin assertion with semantic contract checks:
the reviewer remains mode: subagent with the existing read-only permission
boundaries, must not pin model:/variant: bindings, and must carry the
inheritance/provider-family-affinity policy including OpenAI/OpenAI and
z.ai/z.ai affinity and the no-silent-substitution rule.

Owner-authorized remediation of the only PR #70 blocker.

kilo merged commit 72aedfd51e into develop

2026-10-05 19:41:04 +00:00

kilo deleted branch maintenance/pr-reviewer-binding

2026-10-05 19:41:05 +00:00

kilo referenced this pull request from a commit

2026-10-05 19:41:06 +00:00

Merge pull request 'Make pr-reviewer binding provider/model-agnostic' (#70) from maintenance/pr-reviewer-binding into develop

kilo referenced this pull request

2026-10-05 21:31:43 +00:00

[Kernel][G01 G12] Repair bounded-task lifetime, recovery and original deadline enforcement #48