Clarify implementation commit-history policy #40

New issue

Closed

opened 2026-10-01 00:20:06 +00:00 by kilo · 1 comment

kilo commented

2026-10-01 00:20:06 +00:00

Member

Goal

Remove the materially ambiguous single-commit implication from Kernel's independent repository-local implementation workflow under Adrian's explicit cross-repository remediation.

Why

.kilo/command/implement-issue.md says Commit the smallest coherent change. Implementation delivery must never be judged by commit count.

Scope

Clarify .kilo/rules/30-implementation-discipline.md and the implementation command: commit count is not an acceptance criterion; use as many small, coherent, reviewable commits as needed; remediation commits are normal; never squash, amend, force-push, or rewrite published history merely to reduce count.

Acceptance Criteria

Local rule and command explicitly allow multiple coherent reviewable implementation/remediation commits.
No commit-count acceptance or count-driven history rewrite remains in this workflow.
Legitimate Git object/SHA/transaction and single-issue/PR semantics remain unchanged.
make check, make package-check, and full-base whitespace validation pass; one Forgejo MCP PR targets develop and the issue stays open.

Constraints

Development guidance only. No product/runtime, AGit delivery, routing/reviewer architecture, private configuration, or dependencies change. Isolated branch/worktree from fetched develop; no merge, release, deploy, main change, or published-history rewriting.

Links

Trigger: Creatidy/model-intelligence#2
Shared remediation: DemandTrace/creatidy commit-policy correction.
Explicit owner cross-repository authorization: 2026-10-01.

## Goal Remove the materially ambiguous single-commit implication from Kernel's independent repository-local implementation workflow under Adrian's explicit cross-repository remediation. ## Why `.kilo/command/implement-issue.md` says `Commit the smallest coherent change`. Implementation delivery must never be judged by commit count. ## Scope Clarify `.kilo/rules/30-implementation-discipline.md` and the implementation command: commit count is not an acceptance criterion; use as many small, coherent, reviewable commits as needed; remediation commits are normal; never squash, amend, force-push, or rewrite published history merely to reduce count. ## Acceptance Criteria - Local rule and command explicitly allow multiple coherent reviewable implementation/remediation commits. - No commit-count acceptance or count-driven history rewrite remains in this workflow. - Legitimate Git object/SHA/transaction and single-issue/PR semantics remain unchanged. - `make check`, `make package-check`, and full-base whitespace validation pass; one Forgejo MCP PR targets develop and the issue stays open. ## Constraints Development guidance only. No product/runtime, AGit delivery, routing/reviewer architecture, private configuration, or dependencies change. Isolated branch/worktree from fetched develop; no merge, release, deploy, main change, or published-history rewriting. ## Links - Trigger: https://forgejo.creatidy.com/Creatidy/model-intelligence/pulls/2 - Shared remediation: DemandTrace/creatidy commit-policy correction. - Explicit owner cross-repository authorization: 2026-10-01.

adrian.tkacz referenced this issue from a commit

2026-10-01 00:25:49 +00:00

docs: clarify implementation commit-history policy (#40)

kilo referenced this issue

2026-10-01 00:26:06 +00:00

docs: clarify implementation commit-history policy (#40) #41

kilo commented

2026-10-01 00:26:31 +00:00

Author

Member

Implemented in PR #41: #41 (targets develop; Refs #40).

Only .kilo/rules/30-implementation-discipline.md and .kilo/command/implement-issue.md changed. Both explicitly allow as many small, coherent, reviewable implementation/remediation commits as needed, reject commit-count acceptance, and prohibit count-driven squash/amend/force-push/published-history rewriting while keeping focused scope. No runtime/AGit/routing/reviewer changes.

Base: eb2bcceeafaf1dccc6f6cfba3d456d529eaa0baa; head: bcd30e779d0eaaf5595df2116eac3c892b09ae29.

Validation passed: make check (869 tests; Ruff, basedpyright, import boundaries, secret and whitespace checks), make package-check (build/rebuild, isolated install, CLI replay/export), git diff --cached --check, and git diff --check eb2bcceeafaf1dccc6f6cfba3d456d529eaa0baa HEAD. Full base delta/status/history inspected; base ancestry verified; final worktree clean. Adrian author/committer identity verified; normal Git commit/push succeeded. Audit not needed for docs-only changes.

READY_FOR_REVIEW, not independently reviewed or approved. No reviewer sessions or merge performed; issue remains open. No unresolved implementation blockers.

Implemented in PR #41: https://forgejo.creatidy.com/Creatidy/creatidy-kernel/pulls/41 (targets develop; Refs #40). Only `.kilo/rules/30-implementation-discipline.md` and `.kilo/command/implement-issue.md` changed. Both explicitly allow as many small, coherent, reviewable implementation/remediation commits as needed, reject commit-count acceptance, and prohibit count-driven squash/amend/force-push/published-history rewriting while keeping focused scope. No runtime/AGit/routing/reviewer changes. Base: `eb2bcceeafaf1dccc6f6cfba3d456d529eaa0baa`; head: `bcd30e779d0eaaf5595df2116eac3c892b09ae29`. Validation passed: `make check` (869 tests; Ruff, basedpyright, import boundaries, secret and whitespace checks), `make package-check` (build/rebuild, isolated install, CLI replay/export), `git diff --cached --check`, and `git diff --check eb2bcceeafaf1dccc6f6cfba3d456d529eaa0baa HEAD`. Full base delta/status/history inspected; base ancestry verified; final worktree clean. Adrian author/committer identity verified; normal Git commit/push succeeded. Audit not needed for docs-only changes. READY_FOR_REVIEW, not independently reviewed or approved. No reviewer sessions or merge performed; issue remains open. No unresolved implementation blockers.

adrian.tkacz referenced this issue from a commit

2026-10-03 09:30:47 +00:00

Merge pull request 'docs: clarify implementation commit-history policy (#40)' (#41) from issue-40-commit-policy into develop

adrian.tkacz closed this issue

2026-10-03 09:30:58 +00:00