Creatidy/scarcity-router
5
0
Fork 0
Code Issues 13 Pull requests Projects Releases Packages Wiki Activity Actions

Preserve MI cut on server startup failures (#245) #251

Merged
kilo merged 2 commits from issue-245-mi-startup into develop 2026-11-02 23:12:03 +00:00
Conversation 6 Commits 2 Files changed 5 +258 -21
kilo commented 2026-11-02 21:33:31 +00:00
Member
Copy link

Summary

Bind all configured listeners before atomically activating the MI cut, clean up failed startup, and roll back interrupted MI transactions. Document the durable commit boundary and crash/retry behavior.

Validation

  • Focused deterministic startup, interrupted commit, retained evidence, interleaved replacement and SQLite contention tests passed.
  • uv sync --only-dev --offline; make check (3266 tests, 18 skipped; basedpyright clean); standalone uv run basedpyright; working and staged whitespace checks passed.
  • Synthetic local TLS and disposable stores only; no live inference.
  • Review #1 requested deterministic concurrency coverage; remediation added in 0aef351, pending fresh review.

Base: 481844accb57f5bc092ba9534746c4641e31fc5f
Head: 0aef3514cb74a8c834674f94f9a3d7ca1abad90a

Refs #245

## Summary Bind all configured listeners before atomically activating the MI cut, clean up failed startup, and roll back interrupted MI transactions. Document the durable commit boundary and crash/retry behavior. ## Validation - Focused deterministic startup, interrupted commit, retained evidence, interleaved replacement and SQLite contention tests passed. - `uv sync --only-dev --offline`; `make check` (3266 tests, 18 skipped; basedpyright clean); standalone `uv run basedpyright`; working and staged whitespace checks passed. - Synthetic local TLS and disposable stores only; no live inference. - Review #1 requested deterministic concurrency coverage; remediation added in `0aef351`, pending fresh review. Base: `481844accb57f5bc092ba9534746c4641e31fc5f` Head: `0aef3514cb74a8c834674f94f9a3d7ca1abad90a` Refs #245
Preserve MI cut on startup failures (#245)
All checks were successful
ci / check (pull_request) Successful in 12m43s
Details
23f4e7e071
kilo commented 2026-11-02 21:33:51 +00:00
Author
Member
Copy link

Ordinary independent whole-PR review reservation #1 of maximum 10: requested GPT-6.1 Sol, high reasoning, fresh native user-visible read-only reviewer. Frozen HEAD 23f4e7e0716e663a7366397060577df89339dd93; base and merge-base 481844accb57f5bc092ba9534746c4641e31fc5f. Reservation is not a verdict.

Ordinary independent whole-PR review reservation #1 of maximum 10: requested GPT-6.1 Sol, high reasoning, fresh native user-visible read-only reviewer. Frozen HEAD `23f4e7e0716e663a7366397060577df89339dd93`; base and merge-base `481844accb57f5bc092ba9534746c4641e31fc5f`. Reservation is not a verdict.
kilo commented 2026-11-02 21:34:11 +00:00
Author
Member
Copy link

Review #1 dispatched through native Agent Manager local session ses_e61d1122affe0FnDmR5iDs2f8b, requested GPT-6.1 Sol via openai, high reasoning, read-only pr-reviewer; frozen HEAD/base unchanged. Verdict pending; dispatch metadata is not evidence of runtime backend identity.

Review #1 dispatched through native Agent Manager local session `ses_e61d1122affe0FnDmR5iDs2f8b`, requested `GPT-6.1 Sol` via `openai`, high reasoning, read-only `pr-reviewer`; frozen HEAD/base unchanged. Verdict pending; dispatch metadata is not evidence of runtime backend identity.
kilo commented 2026-11-02 21:37:35 +00:00
Author
Member
Copy link

Review #1 outcome: REQUEST_CHANGES, native session ses_e61d1122affe0FnDmR5iDs2f8b, requested GPT-6.1 Sol/high; reviewed HEAD 23f4e7e0716e663a7366397060577df89339dd93, base/merge-base 481844accb57f5bc092ba9534746c4641e31fc5f. One P2 finding: missing deterministic interleaving coverage for startup versus concurrent accepted MI replacement, including history rejection and transaction contention/serialization. UX: improved startup recovery; no concrete regression. No material access limitations reported. Runtime backend identity is not inferred from dispatch metadata. Review #1 consumed; remediation and a fresh complete review remain required.

Review #1 outcome: REQUEST_CHANGES, native session `ses_e61d1122affe0FnDmR5iDs2f8b`, requested GPT-6.1 Sol/high; reviewed HEAD `23f4e7e0716e663a7366397060577df89339dd93`, base/merge-base `481844accb57f5bc092ba9534746c4641e31fc5f`. One P2 finding: missing deterministic interleaving coverage for startup versus concurrent accepted MI replacement, including history rejection and transaction contention/serialization. UX: improved startup recovery; no concrete regression. No material access limitations reported. Runtime backend identity is not inferred from dispatch metadata. Review #1 consumed; remediation and a fresh complete review remain required.
Cover concurrent MI startup activation (#245)
All checks were successful
ci / check (pull_request) Successful in 12m32s
Details
0aef3514cb
kilo commented 2026-11-02 21:55:30 +00:00
Author
Member
Copy link

Ordinary independent whole-PR review reservation #2 of maximum 10: requested GPT-6.1 Sol, high reasoning, fresh native user-visible read-only reviewer. Frozen HEAD 0aef3514cb74a8c834674f94f9a3d7ca1abad90a; base and merge-base 481844accb57f5bc092ba9534746c4641e31fc5f. Review #1 REQUEST_CHANGES retained; reservation is not a verdict.

Ordinary independent whole-PR review reservation #2 of maximum 10: requested GPT-6.1 Sol, high reasoning, fresh native user-visible read-only reviewer. Frozen HEAD `0aef3514cb74a8c834674f94f9a3d7ca1abad90a`; base and merge-base `481844accb57f5bc092ba9534746c4641e31fc5f`. Review #1 REQUEST_CHANGES retained; reservation is not a verdict.
kilo commented 2026-11-02 21:55:53 +00:00
Author
Member
Copy link

Review #2 dispatched through native Agent Manager local session ses_e61bd4262ffe62hw1H2eRH4f09, requested GPT-6.1 Sol via openai, high reasoning, read-only pr-reviewer; frozen HEAD/base unchanged. Verdict pending; dispatch is not proof of backend identity.

Review #2 dispatched through native Agent Manager local session `ses_e61bd4262ffe62hw1H2eRH4f09`, requested `GPT-6.1 Sol` via `openai`, high reasoning, read-only `pr-reviewer`; frozen HEAD/base unchanged. Verdict pending; dispatch is not proof of backend identity.
kilo commented 2026-11-02 23:11:42 +00:00
Author
Member
Copy link

Review #2 outcome: APPROVE, findings [], limitations [], native read-only session ses_e61bd4262ffe62hw1H2eRH4f09; requested GPT-6.1 Sol/openai/high. Reviewed HEAD 0aef3514cb74a8c834674f94f9a3d7ca1abad90a, base/merge-base 481844accb57f5bc092ba9534746c4641e31fc5f. UX: improved recovery; no material operational UX or security regression identified. Reviewer inspected full frozen diff and contracts; did not run tests. Runtime backend identity is not inferred from dispatch metadata. Forgejo CI run #3499 succeeded for this HEAD.

Review #2 outcome: APPROVE, findings [], limitations [], native read-only session `ses_e61bd4262ffe62hw1H2eRH4f09`; requested GPT-6.1 Sol/openai/high. Reviewed HEAD `0aef3514cb74a8c834674f94f9a3d7ca1abad90a`, base/merge-base `481844accb57f5bc092ba9534746c4641e31fc5f`. UX: improved recovery; no material operational UX or security regression identified. Reviewer inspected full frozen diff and contracts; did not run tests. Runtime backend identity is not inferred from dispatch metadata. Forgejo CI run #3499 succeeded for this HEAD.
kilo merged commit 7985cbadd3 into develop 2026-11-02 23:12:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
P1
Owner-declared highest explicit implementation priority (loop ordering rank)

  
P2
Required product and integration work

  
P3
Deferred or producer-dependent work

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Creatidy/scarcity-router!251
No description provided.