Improve administrator resources and worker UX (#226) #250

Merged
kilo merged 3 commits from issue-226-administrator-ux into develop 2026-11-02 20:48:31 +00:00
Member

Refs #226.

Display configured and source-derived resources using the producer projection, separate discoveries from errors, show source recovery guidance and retired models, expose administrator policy limits, and allow revoked unreferenced worker deletion through the authenticated UI.

Base 10c3ea639280777847605c8f7132fff5a49ef09a; head a60fcde.

Validation: uv sync --only-dev; focused source/UI/worker tests; make check (3258 tests, 18 skipped); uv run basedpyright (0 errors/warnings); make package-check; git diff --check. Synthetic/offline only. Inventory freshness remains unknown after observation, as reported by the producer.

Independent correctness, security, data-integrity and UX review and current-head CI remain pending.

Refs #226. Display configured and source-derived resources using the producer projection, separate discoveries from errors, show source recovery guidance and retired models, expose administrator policy limits, and allow revoked unreferenced worker deletion through the authenticated UI. Base `10c3ea639280777847605c8f7132fff5a49ef09a`; head `a60fcde`. Validation: `uv sync --only-dev`; focused source/UI/worker tests; `make check` (3258 tests, 18 skipped); `uv run basedpyright` (0 errors/warnings); `make package-check`; `git diff --check`. Synthetic/offline only. Inventory freshness remains unknown after observation, as reported by the producer. Independent correctness, security, data-integrity and UX review and current-head CI remain pending.
Improve administrator resource and worker UX (#226)
All checks were successful
ci / check (pull_request) Successful in 12m31s
a60fcde40e
Author
Member

Reserve ordinary independent whole-PR review #1/10 for imminent native reviewer dispatch. Scope: issue #226 complete PR, correctness, security, integrity and practical UX. Frozen HEAD a60fcde40e5521ed3081d253c9c8394ab22008bc; base/merge-base 10c3ea639280777847605c8f7132fff5a49ef09a. Requested GPT-6.1 Sol High; reservation is not a verdict.

Reserve ordinary independent whole-PR review #1/10 for imminent native reviewer dispatch. Scope: issue #226 complete PR, correctness, security, integrity and practical UX. Frozen HEAD `a60fcde40e5521ed3081d253c9c8394ab22008bc`; base/merge-base `10c3ea639280777847605c8f7132fff5a49ef09a`. Requested GPT-6.1 Sol High; reservation is not a verdict.
Author
Member

Review #1/10: REQUEST_CHANGES at HEAD a60fcde40e5521ed3081d253c9c8394ab22008bc, base 10c3ea639280777847605c8f7132fff5a49ef09a; native session ses_e624d0f54ffe2uv2yauEqC0PuJ, requested GPT-6.1 Sol/openai/high, backend runtime identity not independently verified. Finding P2: source guidance incorrectly treats ZCode's healthy unprobeable authentication as a sign-in failure and conflates unavailable runtime with unverified auth; unadmitted ZCode guidance is consequently masked. UX impact: material misleading recovery guidance. Reviewer used canonical SHA-pinned diff/source because checkout permissions denied local access; no reviewer-run tests. Remediation and fresh whole-PR review required.

Review #1/10: REQUEST_CHANGES at HEAD `a60fcde40e5521ed3081d253c9c8394ab22008bc`, base `10c3ea639280777847605c8f7132fff5a49ef09a`; native session `ses_e624d0f54ffe2uv2yauEqC0PuJ`, requested GPT-6.1 Sol/openai/high, backend runtime identity not independently verified. Finding P2: source guidance incorrectly treats ZCode's healthy unprobeable authentication as a sign-in failure and conflates unavailable runtime with unverified auth; unadmitted ZCode guidance is consequently masked. UX impact: material misleading recovery guidance. Reviewer used canonical SHA-pinned diff/source because checkout permissions denied local access; no reviewer-run tests. Remediation and fresh whole-PR review required.
Correct source recovery guidance (#226)
All checks were successful
ci / check (pull_request) Successful in 12m27s
8c0390d630
Author
Member

Review #1 remediation at 8c0390d6309a6bfaec3ab88e277fbd9726847332: source-kind-aware unprobeable authentication and separately unavailable runtime guidance; table-driven cases added. Focused tests pass; full make check 3258 tests, 18 skips, managed basedpyright 0 diagnostics; make package-check and diff whitespace pass. Reserve independent whole-PR review #2/10 at HEAD 8c0390d6309a6bfaec3ab88e277fbd9726847332, base/merge-base 10c3ea639280777847605c8f7132fff5a49ef09a; requested GPT-6.1 Sol High. Reservation is not approval.

Review #1 remediation at `8c0390d6309a6bfaec3ab88e277fbd9726847332`: source-kind-aware unprobeable authentication and separately unavailable runtime guidance; table-driven cases added. Focused tests pass; full `make check` 3258 tests, 18 skips, managed basedpyright 0 diagnostics; `make package-check` and diff whitespace pass. Reserve independent whole-PR review #2/10 at HEAD `8c0390d6309a6bfaec3ab88e277fbd9726847332`, base/merge-base `10c3ea639280777847605c8f7132fff5a49ef09a`; requested GPT-6.1 Sol High. Reservation is not approval.
Author
Member

Independent whole-PR review #2/10: APPROVE, findings [], at exact HEAD 8c0390d6309a6bfaec3ab88e277fbd9726847332, base/merge-base 10c3ea639280777847605c8f7132fff5a49ef09a. Fresh read-only native session ses_e6237d56dffeL25BLyBg0kLSrt; dispatch GPT-6.1 Sol/openai/high, backend runtime identity not independently observable. Reviewer inspected complete canonical diff and SHA-pinned source/contracts, including security, worker deletion, audit storage and UX; no reviewer-run tests. UX impact: improvements, no material regression. Current-head Forgejo CI remains pending.

Independent whole-PR review #2/10: APPROVE, findings [], at exact HEAD `8c0390d6309a6bfaec3ab88e277fbd9726847332`, base/merge-base `10c3ea639280777847605c8f7132fff5a49ef09a`. Fresh read-only native session `ses_e6237d56dffeL25BLyBg0kLSrt`; dispatch GPT-6.1 Sol/openai/high, backend runtime identity not independently observable. Reviewer inspected complete canonical diff and SHA-pinned source/contracts, including security, worker deletion, audit storage and UX; no reviewer-run tests. UX impact: improvements, no material regression. Current-head Forgejo CI remains pending.
Author
Member

Acceptance verification remains open despite review #2 APPROVE and exact-head CI #3492 success: the producer currently emits discovered/routable decisions, while the new restricted and error counter branches do not have demonstrated real producer inputs. The requested table-driven coverage of all counter categories and proof of accurate nonzero restricted/error semantics are not yet established. No merge or issue closure claimed.

Acceptance verification remains open despite review #2 APPROVE and exact-head CI #3492 success: the producer currently emits `discovered`/`routable` decisions, while the new `restricted` and `error` counter branches do not have demonstrated real producer inputs. The requested table-driven coverage of all counter categories and proof of accurate nonzero restricted/error semantics are not yet established. No merge or issue closure claimed.
Report source counter availability honestly (#226)
All checks were successful
ci / check (pull_request) Successful in 12m41s
cb86e95068
Author
Member

Owner's bounded counter clarification is recorded at #226 comment 20776. Correction cb86e95068efdde4e1cb7bc8a4856dd570bb4880 counts routable, local policy exclusions and remaining discoveries from actual current producer facts; legacy numeric errors field is explicitly marked errors_reported: false and UI says not reported. Focused and full gate pass: 3259 tests, 18 skips, basedpyright 0 diagnostics, package check and whitespace pass. Reserve imminent independent whole-PR review #3, requested GPT-6.1 Sol/openai/high, HEAD cb86e95068efdde4e1cb7bc8a4856dd570bb4880, base/merge-base 10c3ea639280777847605c8f7132fff5a49ef09a. Review #1 REQUEST_CHANGES and #2 APPROVE remain historical; #2 is invalidated by this HEAD. Reservation is not a verdict.

Owner's bounded counter clarification is recorded at #226 comment 20776. Correction `cb86e95068efdde4e1cb7bc8a4856dd570bb4880` counts routable, local policy exclusions and remaining discoveries from actual current producer facts; legacy numeric errors field is explicitly marked `errors_reported: false` and UI says not reported. Focused and full gate pass: 3259 tests, 18 skips, basedpyright 0 diagnostics, package check and whitespace pass. Reserve imminent independent whole-PR review #3, requested GPT-6.1 Sol/openai/high, HEAD `cb86e95068efdde4e1cb7bc8a4856dd570bb4880`, base/merge-base `10c3ea639280777847605c8f7132fff5a49ef09a`. Review #1 REQUEST_CHANGES and #2 APPROVE remain historical; #2 is invalidated by this HEAD. Reservation is not a verdict.
Author
Member

Independent whole-PR review #3: APPROVE, findings [], exact HEAD cb86e95068efdde4e1cb7bc8a4856dd570bb4880, base/merge-base 10c3ea639280777847605c8f7132fff5a49ef09a; fresh native read-only session ses_e62073f42ffeWHDU0LJjV7egk3, dispatched GPT-6.1 Sol/openai/high (backend runtime identity independently unobserved). Reviewer inspected complete canonical diff and frozen Git objects, counter producer semantics, security, integrity, compatibility and UX; no material UX regression, no reviewer-run tests. Exact-head CI remains pending.

Independent whole-PR review #3: APPROVE, findings [], exact HEAD `cb86e95068efdde4e1cb7bc8a4856dd570bb4880`, base/merge-base `10c3ea639280777847605c8f7132fff5a49ef09a`; fresh native read-only session `ses_e62073f42ffeWHDU0LJjV7egk3`, dispatched GPT-6.1 Sol/openai/high (backend runtime identity independently unobserved). Reviewer inspected complete canonical diff and frozen Git objects, counter producer semantics, security, integrity, compatibility and UX; no material UX regression, no reviewer-run tests. Exact-head CI remains pending.
kilo merged commit 481844accb into develop 2026-11-02 20:48:31 +00:00
Sign in to join this conversation.
No description provided.