[P1][workflow] Allow private Forgejo MCP reads in independent PR review #207

New issue

Closed

opened 2026-10-11 15:37:50 +00:00 by kilo · 1 comment

kilo commented

2026-10-11 15:37:50 +00:00

Member

Problem

.kilo/agents/pr-reviewer.md requires anonymous canonical git ls-remote, preventing independent review when Git transport is private or unavailable to the reviewer.

Authorized behavior and scope

Use read-only Forgejo MCP metadata to verify canonical repository identity, current open PR, head/base refs and exact commit identities. Verify independently against the primary-prepared clean local checkout, exact SHA objects, merge base and complete whole-PR diff. Anonymous git ls-remote is optional corroboration only. Reviewer credentials remain unavailable to model/shell; MCP must not disclose tokens. Keep normal Git for implementation fetch/branch/commit/push; reviewer MCP stays read-only with no file writes or repository mutations. Preserve fresh context, frozen HEAD/base, ordinals, existing provider/model policy, required CI/validation, merge authority, and all additional restricted/security reviewer rules.

Affected: .kilo/agents/pr-reviewer.md, applicable command/rule references and workflow contract tests only as needed.

Acceptance

A private/no-anonymous-Git case reviews successfully only when canonical MCP metadata and prepared exact local Git evidence agree; missing/mismatched evidence refuses approval. Regression tests preserve security restrictions and full review gates.

Non-goals

No credential access, MCP writes, implementation/integration, security-policy relaxation or weakened independent review.

## Problem `.kilo/agents/pr-reviewer.md` requires anonymous canonical `git ls-remote`, preventing independent review when Git transport is private or unavailable to the reviewer. ## Authorized behavior and scope Use read-only Forgejo MCP metadata to verify canonical repository identity, current open PR, head/base refs and exact commit identities. Verify independently against the primary-prepared clean local checkout, exact SHA objects, merge base and complete whole-PR diff. Anonymous `git ls-remote` is optional corroboration only. Reviewer credentials remain unavailable to model/shell; MCP must not disclose tokens. Keep normal Git for implementation fetch/branch/commit/push; reviewer MCP stays read-only with no file writes or repository mutations. Preserve fresh context, frozen HEAD/base, ordinals, existing provider/model policy, required CI/validation, merge authority, and all additional restricted/security reviewer rules. Affected: `.kilo/agents/pr-reviewer.md`, applicable command/rule references and workflow contract tests only as needed. ## Acceptance A private/no-anonymous-Git case reviews successfully only when canonical MCP metadata and prepared exact local Git evidence agree; missing/mismatched evidence refuses approval. Regression tests preserve security restrictions and full review gates. ## Non-goals No credential access, MCP writes, implementation/integration, security-policy relaxation or weakened independent review.

adrian.tkacz referenced this issue from a commit

2026-10-11 18:23:12 +00:00

Allow private Forgejo MCP review reads (#207)

kilo referenced this issue

2026-10-11 18:23:17 +00:00

Allow private Forgejo MCP reads in independent review #208

kilo commented

2026-10-11 18:23:52 +00:00

Author

Member

Implemented in PR #208: BioMedical-IT/scarcity-router#208

READY_TO_MERGE. Reviewer now uses canonical read-only Forgejo metadata plus exact local Git evidence, without requiring anonymous Git access. Security/read-only gates preserved; shared rule and focused regression test updated.

Final validation PASS: make check, focused contract test, uv run basedpyright, whitespace checks. Fresh independent whole-PR review ordinal 4 APPROVE with no findings; authorized fresh-context fallback used because startup-loaded pr-reviewer instructions were stale. Final canonical refs match and checkout is clean.

Base edd31326d4abe5cc282adb419cb54c78d4677ec4; head a7a8108160d7bf8c31cca157a2e1b3ee42e12a66. PR and issue remain open; no merge or deployment. Already-loaded Kilo agent configuration may require a workspace reload.

Implemented in PR #208: https://forgejo.creatidy.com/BioMedical-IT/scarcity-router/pulls/208 READY_TO_MERGE. Reviewer now uses canonical read-only Forgejo metadata plus exact local Git evidence, without requiring anonymous Git access. Security/read-only gates preserved; shared rule and focused regression test updated. Final validation PASS: `make check`, focused contract test, `uv run basedpyright`, whitespace checks. Fresh independent whole-PR review ordinal 4 APPROVE with no findings; authorized fresh-context fallback used because startup-loaded pr-reviewer instructions were stale. Final canonical refs match and checkout is clean. Base `edd31326d4abe5cc282adb419cb54c78d4677ec4`; head `a7a8108160d7bf8c31cca157a2e1b3ee42e12a66`. PR and issue remain open; no merge or deployment. Already-loaded Kilo agent configuration may require a workspace reload.

adrian.tkacz referenced this issue from a commit

2026-10-11 18:38:13 +00:00

Authorize exact repo metadata in review manifest (#207)

adrian.tkacz referenced this issue from a commit

2026-10-11 18:55:33 +00:00

Explicitly deny reviewer Git remote reads (#207)

adrian.tkacz referenced this issue from a commit

2026-10-11 19:23:22 +00:00

Permit focused source-only reviewer contract check (#207)

adrian.tkacz closed this issue

2026-10-11 19:37:15 +00:00