workflow: trace loop dependency evidence (#88) #89

Merged

adrian.tkacz merged 4 commits from issue-88-dependency-evidence-loop into develop

2026-10-11 18:13:05 +00:00

kilo commented

2026-10-11 16:58:39 +00:00

Member

Refs #88

Scope

Development workflow only: refresh canonical issue/dependency and producer-contract evidence before eligibility/inactivity outcomes; trace explicit chains to executable predecessors; distinguish issue-local gates from repository-wide inactivity; classify unknown evidence as UNVERIFIED, never false QUEUE_EMPTY; retain nonterminal technical recovery and existing authority, re-selection, history, independence, security, validation and merge rules. Offline semantic cases cover chains, branching order, unknown evidence, unrelated eligible work, verified exhaustion and nonterminal recovery. No product/API/runtime changes.

Review History

All reviews used base 8c49f61bb6ea4bfbb0f38a0868339647feba6396. History and delivery counter retained; 7/10 consumed.

Ordinal	HEAD	Result
1	`043ced035c`	COMMENT infrastructure, mandatory anonymous Git claimed by loaded reviewer; checked-in contract supports MCP refs
2	`043ced035c`	REQUEST_CHANGES, dependency early-return finding fixed in `cd62f48`
3	`cd62f48d19`	COMMENT with branching-order finding and denied combined shell verification; fixed in `d468aba`
4	`d468abadd4`	APPROVE, historical and superseded by later finding/new HEAD
5	`d468abadd4`	Subsequent owner-selected review: COMMENT infrastructure, conflicting effective native Git prerequisite; kilo diagnostic executable unavailable
6	`d468abadd4`	Fresh equivalent independent read-only review REQUEST_CHANGES, locally gated parent concealed missing/stale dependencies
7	`922b3e6912`	Fresh equivalent independent full review APPROVE, no findings; exact MCP/local refs and required checks passed

Latest Remediation

Owner requested fixes to ordinal 6 finding. Normal commit 922b3e6 defers local gate classification until dependency traversal, preventing missing/changed/inaccessible evidence from producing QUEUE_EMPTY. Regressions failed before fix and now pass: unknown queue remains UNVERIFIED; unrelated confirmed eligible work still selects; fully verified gate remains GATED. Only tests/test_workflow_contract.py changed in this remediation.

Current Validation

Closed synthetic environment and existing locked/offline tooling:

Focused workflow tests: 25 passed, 106 subtests passed.
make check: passed; 1437 passed, 85 optional-native skipped, 106 subtests passed; Ruff, basedpyright, inward imports, secrets and whitespace passed.
make package-check: reproducible wheel/sdist, isolated installation and CLI/intake/source smokes passed.
No dependency/tooling change; audit not required.

Frozen Revisions And Handoff

Base/merge-base: 8c49f61bb6ea4bfbb0f38a0868339647feba6396
Current independently approved HEAD: 922b3e69121879649de8baa0d76260b6c1555642
Post-review Git/MCP currentness verified, clean checkout; open/unmerged canonical develop-target PR.

READY_TO_MERGE, not merged. Issue #88 remains open. Validation covers offline workflow guidance and semantic guards, not live loop/native harness conformance. No changes to issue #53/PR #85 or their delivery history.

Refs #88 ## Scope Development workflow only: refresh canonical issue/dependency and producer-contract evidence before eligibility/inactivity outcomes; trace explicit chains to executable predecessors; distinguish issue-local gates from repository-wide inactivity; classify unknown evidence as `UNVERIFIED`, never false `QUEUE_EMPTY`; retain nonterminal technical recovery and existing authority, re-selection, history, independence, security, validation and merge rules. Offline semantic cases cover chains, branching order, unknown evidence, unrelated eligible work, verified exhaustion and nonterminal recovery. No product/API/runtime changes. ## Review History All reviews used base `8c49f61bb6ea4bfbb0f38a0868339647feba6396`. History and delivery counter retained; 7/10 consumed. | Ordinal | HEAD | Result | | --- | --- | --- | | 1 | 043ced035c7c8ae28ee658673eeb8224e494eab5 | COMMENT infrastructure, mandatory anonymous Git claimed by loaded reviewer; checked-in contract supports MCP refs | | 2 | 043ced035c7c8ae28ee658673eeb8224e494eab5 | REQUEST_CHANGES, dependency early-return finding fixed in cd62f48 | | 3 | cd62f48d191ec8b5b3728eed5b6e6c1ee216fc27 | COMMENT with branching-order finding and denied combined shell verification; fixed in d468aba | | 4 | d468abadd4a45e2a804e1bb8988d02fc5888cc21 | APPROVE, historical and superseded by later finding/new HEAD | | 5 | d468abadd4a45e2a804e1bb8988d02fc5888cc21 | Subsequent owner-selected review: COMMENT infrastructure, conflicting effective native Git prerequisite; kilo diagnostic executable unavailable | | 6 | d468abadd4a45e2a804e1bb8988d02fc5888cc21 | Fresh equivalent independent read-only review REQUEST_CHANGES, locally gated parent concealed missing/stale dependencies | | 7 | 922b3e69121879649de8baa0d76260b6c1555642 | Fresh equivalent independent full review APPROVE, no findings; exact MCP/local refs and required checks passed | ## Latest Remediation Owner requested fixes to ordinal 6 finding. Normal commit `922b3e6` defers local gate classification until dependency traversal, preventing missing/changed/inaccessible evidence from producing QUEUE_EMPTY. Regressions failed before fix and now pass: unknown queue remains UNVERIFIED; unrelated confirmed eligible work still selects; fully verified gate remains GATED. Only tests/test_workflow_contract.py changed in this remediation. ## Current Validation Closed synthetic environment and existing locked/offline tooling: - Focused workflow tests: 25 passed, 106 subtests passed. - `make check`: passed; 1437 passed, 85 optional-native skipped, 106 subtests passed; Ruff, basedpyright, inward imports, secrets and whitespace passed. - `make package-check`: reproducible wheel/sdist, isolated installation and CLI/intake/source smokes passed. - No dependency/tooling change; audit not required. ## Frozen Revisions And Handoff - Base/merge-base: `8c49f61bb6ea4bfbb0f38a0868339647feba6396` - Current independently approved HEAD: `922b3e69121879649de8baa0d76260b6c1555642` - Post-review Git/MCP currentness verified, clean checkout; open/unmerged canonical develop-target PR. READY_TO_MERGE, not merged. Issue #88 remains open. Validation covers offline workflow guidance and semantic guards, not live loop/native harness conformance. No changes to issue #53/PR #85 or their delivery history.

kilo added 1 commit

2026-10-11 16:58:39 +00:00